-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid @NonNullApi and null return #871
Comments
This is bug. The method and its contract in the Feel free to provide a fix on the matter! Thanks! |
Sure. PR is there. I'm hoping this was right for this project and I had not missing some (non technical). btw: I have noticed the same issue with |
That one has to be fixed as well. There is no obligation from end-user to return something specific from that lambda implementation.
So, this one has to be Thanks |
Hi,
I have noticed an invalid nullable situation within spring-rabbit's API.
At least the method
org.springframework.amqp.rabbit.core.RabbitAdmin#getQueueProperties
is nullable (I think it was nullable alway as I'm using this for explicit queue management on startup for years) as the code clearly shows (in the local exception handling) as well as the documentation clearly statesHowever, the package contains a
@NonNullApi
also. And as I had understand this correctly, either this one is not correct, or there is a@Nullable
missing, or the code should not returnnull
.The issue got into my attention as IntelliJ hints about a redundant null check. Fortunately, I have checked this.
The text was updated successfully, but these errors were encountered: