Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpringMultirabbit for auto-configuration of multiple ConnectionFactories #891

Closed
rwanderc opened this issue Jan 26, 2019 · 3 comments · Fixed by #1111
Closed

SpringMultirabbit for auto-configuration of multiple ConnectionFactories #891

rwanderc opened this issue Jan 26, 2019 · 3 comments · Fixed by #1111

Comments

@rwanderc
Copy link
Contributor

Enhancement

Recently I created a blog post about SpringMultirabbit. This is a solution to provide multiple ConnectionFactories, auto-configured, extending RabbitProperties, so as to have a simpler way to introduce different brokers in applications (e.g.: one for configuration hot-reloading and another for business events). This feature is available at http://github.com/mytaxi/spring-multirabbit

Out of the comments, @garyrussell suggested to contribute this work to the framework.
I have already followed the instructions at Contributor Guidelines. However, couldn't find how to create the issue in Jira AMQP project, thus, I'm creating here in GitHub.

Before submitting the PRs, I wanted to know if there are any further instructions or concerns.

@garyrussell
Copy link
Contributor

@rwanderc Sorry about that - we recently switched from JIRA to GitHub issues; there's a note on the JIRA home page, but we haven't updated the contributor guidelines yet.

My only thoughts/concerns is that some of the classes in the boot autoconfiguration part might belong here instead (ConnectionFactoryContextWrapper might be an example), so that non-boot users can use this functionality.

Obviously, the boot-specific parts will need to be a separate contribution over there, once this is merged. I haven't talked to the boot team yet, but I don't anticipate any problems with them accepting a PR.

I like the idea of auto-determining the admins but we might be able to make it simpler than using naming conventions, perhaps by adding a getter on the admin so we can match admin and container factory connection factories. That functionality can be merged into the main BPP rather than subclassing it.

Anyway, welcome; we look forward to working with you.

@garyrussell garyrussell added this to the 2.2.x milestone Jan 26, 2019
@rwanderc
Copy link
Contributor Author

PR created #1111

@garyrussell
Copy link
Contributor

Nice PR# 😄

garyrussell pushed a commit that referenced this issue Jun 24, 2020
* GH-891 Introduced MultiRabbit for handle multiple brokers

* GH-891 Fixed formatting and conventions

* GH-891 Avoid premature load of factory beans and some minor refactoring

* GH-891 Introduced tests for SpringMultirabbit

* GH-891 Modified BPP to return list of Declarables created

* GH-891 Minor refactoring

* GH-891 Updated copyright year

* GH-891 Introduced default setAdminsThatShouldDeclare() into Declarable

* GH-891 Avoiding premature instantiation of RabbitAdmin by providing the bean name instead

* GH-891 Changed to non-default

* GH-891 Removed MultiRabbitBootstrapConfiguration and its test
@artembilan artembilan modified the milestones: Backlog, 2.3.M1 Aug 20, 2020
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Oct 27, 2020
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Oct 27, 2020
artembilan pushed a commit that referenced this issue Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants