Update setUsePublisherConnection javadocs #1100
Conversation
Docs in setUsePublisherConnection say this defaults to true since version 2.1 what, in my opinion, is not true
|
@kjastrzebski Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@kjastrzebski Thank you for signing the Contributor License Agreement! |
| @@ -245,7 +245,7 @@ | |||
|
|
|||
| private boolean userCorrelationId; | |||
|
|
|||
| private boolean usePublisherConnection; | |||
| private boolean usePublisherConnection = true; | |||
There was a problem hiding this comment.
We need to change the javadoc instead. It turned out that true is not a safe default and will break many existing applications.
The problem is that any auto-delete, exclusive Queue beans in the application context will be declared on the producer connection and any listener containers that consume from those queues will fail to start because they can only be accessed on the connection on which they were declared.
You can see many examples of this in the travis report (failed tests).
|
Ok, so let's change the javadocs as users may be confused by them |
kjastrzebski
changed the title
Docs in setUsePublisherConnection say this defaults to true since version 2.1 what, in my opinion, is not true