Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Databases that support embedded and non-embedded modes are always detected as embedded #23721

Closed
snicoll opened this issue Oct 16, 2020 · 1 comment
Closed

Databases that support embedded and non-embedded modes are always detected as embedded #23721

snicoll opened this issue Oct 16, 2020 · 1 comment
Assignees
@snicoll
Labels
status: declined A suggestion or change that we don't feel we should currently apply type: task A general task

Comments

@snicoll
Copy link
Member

snicoll commented Oct 16, 2020 •
edited
Loading

backport of #23693 in 2.3.x.
@snicoll snicoll added the type: bug A general bug label Oct 16, 2020
@snicoll snicoll added this to the 2.3.5 milestone Oct 16, 2020
@snicoll snicoll self-assigned this Oct 16, 2020
@snicoll snicoll mentioned this issue Oct 16, 2020
Closed
@snicoll
Copy link
Member Author

snicoll commented Oct 19, 2020 •
edited
Loading

By switching from sa to null for non-embedded use cases, any file-based database that was created prior to upgrading will require users to set the username (spring.datasource.username=sa).

I don't think the related problem (being able to user a file-based database without a username is worth breaking this use case so I am going to revert the backport.

@snicoll snicoll added status: declined A suggestion or change that we don't feel we should currently apply type: task A general task and removed type: bug A general bug labels Oct 19, 2020
@snicoll snicoll removed this from the 2.3.5 milestone Oct 19, 2020
snicoll added a commit that referenced this issue Oct 19, 2020
@snicoll
Revert "Fix detection logic for embedded databases"
dd74810 
This reverts commit c4a5a34.

See gh-23721
@snicoll snicoll mentioned this issue Oct 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
status: declined A suggestion or change that we don't feel we should currently apply type: task A general task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@snicoll