Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spring.factories auto-configuration support #29699

Closed
philwebb opened this issue Feb 9, 2022 · 4 comments
Closed

Remove spring.factories auto-configuration support #29699

philwebb opened this issue Feb 9, 2022 · 4 comments
Assignees
Labels
type: task A general task
Milestone

Comments

@philwebb
Copy link
Member

philwebb commented Feb 9, 2022

When #29698 has been finished in 2.7.x we should fully remove spring.factories support in 3.0.x

@philwebb philwebb added this to the 3.0.x milestone Feb 9, 2022
@philwebb philwebb added the type: task A general task label Feb 9, 2022
@scottfrederick scottfrederick added the status: blocked An issue that's blocked on an external project change label Feb 9, 2022
@mhalbritter mhalbritter removed the status: blocked An issue that's blocked on an external project change label Mar 9, 2022
@snicoll snicoll added the status: on-hold We can't start working on this issue yet label Mar 18, 2022
@snicoll
Copy link
Member

snicoll commented Mar 18, 2022

We've discussed this one today and concluded that it would be better if we wait for a release that contains the @AutoConfiguration change so that the community have a chance to adapt their starter before we remove support in 3.0.

Given the timeline for 2.7, we are considering this in Spring Boot 3.0.0-M4.

@kdebski85
Copy link

I am using 2.7, and I read that spring.factories is deprecated, and it will be removed.

My spring.factories contains only one line:
org.springframework.boot.env.EnvironmentPostProcessor=com.myorg.PropertySourceEnvironmentPostProcessor

com.myorg.PropertySourceEnvironmentPostProcessor class implements org.springframework.boot.env.EnvironmentPostProcessor and it does not have any annotation.

It is not clear to me if @AutoConfiguration annotation also supports EnvironmentPostProcessor.
Environment post processor must run before starting application context.
Maybe documentation should be expanded how to use custom environment post processor in Spring Boot 3.

@wilkinsona
Copy link
Member

wilkinsona commented Jun 24, 2022

I read that spring.factories is deprecated, and it will be removed.

spring.factories is not deprecated and isn't going to be removed. Where did you read that?

Maybe documentation should be expanded how to use custom environment post processor in Spring Boot 3.

The change that we've made only affects auto-configuration classes. All other entries in spring.factories, including environment post-processors, are unaffected so there is nothing more to document.

@snicoll snicoll removed the status: on-hold We can't start working on this issue yet label Jul 19, 2022
@wilkinsona wilkinsona modified the milestones: 3.0.0-M4, 3.0.0-M5 Jul 19, 2022
@wilkinsona
Copy link
Member

As agreed with @spencergibb, these changes should not be made until the week beginning 12 September.

@wilkinsona wilkinsona added the status: on-hold We can't start working on this issue yet label Jul 19, 2022
@scottfrederick scottfrederick self-assigned this Sep 20, 2022
@scottfrederick scottfrederick removed the status: on-hold We can't start working on this issue yet label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

6 participants