Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor timeouts in Zipkin WebClient sender #31496

Closed
Tracked by #35776
mhalbritter opened this issue Jun 22, 2022 · 1 comment
Closed
Tracked by #35776

Honor timeouts in Zipkin WebClient sender #31496

mhalbritter opened this issue Jun 22, 2022 · 1 comment
Assignees
@mhalbritter
Labels
theme: observability Issues related to observability type: enhancement A general enhancement
Milestone
3.2.0-RC1

Comments

@mhalbritter
Copy link
Contributor

The WebClientSenderConfiguration contains the auto-configuration for the WebClient based Zipkin sender. The RestTemplate based one honors the timeouts from the ZipkinProperties, while the WebClient based one does not. Unfortunately there is no client agnostic way to set the timeouts (the PR set the timeouts via a ReactorHttpClient, which ties the implementation to Netty).

Investigate if we can make this happen nonetheless, or at least document that the timeouts aren't honored with the WebClient one. Maybe we can use the timeout methods from Reactor somehow to workaround.
@mhalbritter mhalbritter added the type: enhancement A general enhancement label Jun 22, 2022
@mhalbritter mhalbritter added this to the 3.0.x milestone Jun 22, 2022
@mhalbritter mhalbritter added the theme: observability Issues related to observability label Jul 19, 2022
@philwebb philwebb modified the milestones: 3.0.x, 3.1.x Oct 17, 2022
@wilkinsona wilkinsona mentioned this issue Oct 24, 2022
Closed
@philwebb philwebb mentioned this issue Mar 22, 2023
Open
@wilkinsona wilkinsona modified the milestones: 3.1.x, 3.x Apr 17, 2023
@philwebb philwebb mentioned this issue Jun 7, 2023
Closed
31 tasks
@mhalbritter mhalbritter self-assigned this Sep 25, 2023
mhalbritter added a commit to mhalbritter/spring-boot that referenced this issue Sep 25, 2023
@mhalbritter
Honor timeout in ZipkinWebClientSender
0fa97bc 
Unfortunately there's no good way to configure connect and read timeout
separately, which works for all supported reactive clients. This
implementation applies a timeout through Reactor's timeout method. The
timeout from the properties is summed together and this is the applied
timeout. While not perfect, this is better than no timeout at all.

Closes spring-projectsgh-31496
@mhalbritter
Copy link
Contributor Author

I have some changes here: https://github.com/mhalbritter/spring-boot/tree/mh/31496-honor-timeouts-in-zipkin-webclient-sender

@mhalbritter mhalbritter modified the milestones: 3.x, 3.2.0-RC1 Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhalbritter mhalbritter

Labels
theme: observability Issues related to observability type: enhancement A general enhancement
Projects
None yet
Milestone
3.2.0-RC1
Development

No branches or pull requests
3 participants
@philwebb @wilkinsona @mhalbritter