Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auto-configuration for OTLP span exporter #34390

Closed
making opened this issue Feb 27, 2023 · 4 comments
Closed

Add auto-configuration for OTLP span exporter #34390

making opened this issue Feb 27, 2023 · 4 comments
Assignees
@jonatan-ivanov
Labels
status: superseded An issue that has been superseded by another theme: observability Issues related to observability type: enhancement A general enhancement

Comments

@making
Copy link
Member

making commented Feb 27, 2023

Currently, only Zipkin (ZipkinSpanExporter) and Wavefront (WavefrontOtelSpanExporter) exporters are supported in auto configuration when using OpenTelemetry as the tracer.
Since there are many OpenTelemetry backends that support OTLP, it would be very useful to have OTLP exporter support as well.

Actually spring-cloud-sleuth-otel has such an auto configuration.
https://github.com/spring-projects-experimental/spring-cloud-sleuth-otel/blob/main/spring-cloud-sleuth-otel-autoconfigure/src/main/java/org/springframework/cloud/sleuth/autoconfig/otel/OtelExporterConfiguration.java
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 27, 2023
@mhalbritter mhalbritter added type: enhancement A general enhancement theme: observability Issues related to observability and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 27, 2023
@mhalbritter mhalbritter added this to the 3.x milestone Feb 27, 2023
@jonatan-ivanov jonatan-ivanov self-assigned this Mar 1, 2023
@jonatan-ivanov jonatan-ivanov modified the milestones: 3.x, 3.1.x Mar 1, 2023
@uniquejava
Copy link

Yes, I found Jaeger UI is more user friendly when displaying tracing data(e.g. Better span name and SQL displayed nicely inside span)

I wish spring boot 3 (micrometer) can export trace data to Jaeger. Like what it used to do with spring cloud sleuth.

@jonatan-ivanov
Copy link
Member

This issue is about OTLP really, does not have too much to do with Jaeger specifically. The Jaeger collector can accept spans in the Zipkin format so you should be able to use Jaeger out of the box. Right now you can create a JaegerGrpcSpanExporter but if you want Boot to do it for you, could you please open an issue for it?

@wilkinsona wilkinsona changed the title Add autoconfiguration for OTLP span exporter Add auto-configuration for OTLP span exporter Mar 3, 2023
@sivaprasadreddy
Copy link

Followed @jonatan-ivanov hint and get Jaeger working. Here is a sample repo https://github.com/sivaprasadreddy/spring-boot-opentelemetry-demo

However, as Jaeger is a very popular choice, having auto-configuration support would be great.

jonatan-ivanov added a commit to jonatan-ivanov/spring-boot that referenced this issue Mar 7, 2023
@jonatan-ivanov
Add auto-configuration for OTLP span exporter
544870f 
With these changes an OTLP exporter is auto-configured
if opentelemetry-exporter-otlp is on the classpath
by default HTTP is used but gRPC is also available

Closes spring-projectsgh-34390
jonatan-ivanov added a commit to jonatan-ivanov/spring-boot that referenced this issue Mar 7, 2023
@jonatan-ivanov
Add auto-configuration for OTLP span exporter
7920a1c 
With these changes an OTLP exporter is auto-configured
if opentelemetry-exporter-otlp is on the classpath.
By default HTTP is used but gRPC is also available.

Closes spring-projectsgh-34390
@jonatan-ivanov jonatan-ivanov mentioned this issue Mar 7, 2023
Closed
jonatan-ivanov added a commit to jonatan-ivanov/spring-boot that referenced this issue Mar 9, 2023
@jonatan-ivanov
Add auto-configuration for OTLP span exporter
d979657 
With these changes an OTLP HTTP/protobuf exporter is auto-configured
if opentelemetry-exporter-otlp is on the classpath.

Closes spring-projectsgh-34390
jonatan-ivanov added a commit to jonatan-ivanov/spring-boot that referenced this issue Mar 9, 2023
@jonatan-ivanov
Add auto-configuration for OTLP span exporter
9988fd6 
With these changes an OTLP HTTP/protobuf exporter is auto-configured
if opentelemetry-exporter-otlp is on the classpath.

Closes spring-projectsgh-34390
@shakuzen shakuzen mentioned this issue Mar 23, 2023
Closed
@wilkinsona
Copy link
Member

Closing in favor of #34508.

@wilkinsona wilkinsona closed this as not planned Won't fix, can't repro, duplicate, stale Apr 14, 2023
@wilkinsona wilkinsona removed this from the 3.1.x milestone Apr 14, 2023
@wilkinsona wilkinsona added the status: superseded An issue that has been superseded by another label Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonatan-ivanov jonatan-ivanov

Labels
status: superseded An issue that has been superseded by another theme: observability Issues related to observability type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add auto-configuration for OTLP span exporter jonatan-ivanov/spring-boot
7 participants
@making @sivaprasadreddy @wilkinsona @uniquejava @jonatan-ivanov @spring-projects-issues @mhalbritter