Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register user-provided SdkLoggerProvider and SdkMeterProvider on the OpenTelemetry bean #36545

Closed
Tracked by #35776
mhalbritter opened this issue Jul 25, 2023 · 1 comment
Closed
Tracked by #35776

Register user-provided SdkLoggerProvider and SdkMeterProvider on the OpenTelemetry bean #36545

mhalbritter opened this issue Jul 25, 2023 · 1 comment
Assignees
@mhalbritter
Labels
theme: observability Issues related to observability type: enhancement A general enhancement
Milestone
3.2.0-M2

Comments

@mhalbritter
Copy link
Contributor

mhalbritter commented Jul 25, 2023 •
edited
Loading

We currently have auto-configuration for tracing via OpenTelemetry, by providing a SdkTracerProvider and ContextPropagators bean, which get registered on the OpenTelemetry bean.

OpenTelemetry supports metrics and logging, too. At the moment we don't want to auto-configure full support for that, but we should register the SdkLoggerProvider and SdkMeterProvider on the OpenTelemetry bean if they are in the application context.

This makes it easier for users who supply those beans themselves.
@mhalbritter mhalbritter added type: enhancement A general enhancement theme: observability Issues related to observability labels Jul 25, 2023
@mhalbritter mhalbritter added this to the 3.2.x milestone Jul 25, 2023
@mhalbritter mhalbritter self-assigned this Jul 25, 2023
@mhalbritter
Copy link
Contributor Author

mhalbritter commented Jul 25, 2023 •
edited
Loading

I sketched something here: ccf9fc7

This was referenced Jul 25, 2023
Closed
Open
Closed
mhalbritter added a commit to mhalbritter/spring-boot that referenced this issue Jul 25, 2023
@mhalbritter
Split OpenTelemetry auto-configuration
87f9268 
The OpenTelemetry bean is now configured in the
OpenTelemetryAutoConfiguration. This method also applies
SdkLoggerProvider and SdkMeterProvider.

Additionally, the OpenTelemetry Resource is now a bean. Resource
attributes can now be configured through properties

The resourceAttributes in OtlpProperties have been deprecated in favor
of the new one in OpenTelemetryProperties.

Closes spring-projectsgh-36544
Closes spring-projectsgh-36545
mhalbritter added a commit to mhalbritter/spring-boot that referenced this issue Jul 25, 2023
@mhalbritter
Split OpenTelemetry auto-configuration
51c5a88 
The OpenTelemetry bean is now configured in the
OpenTelemetryAutoConfiguration. This method also applies
SdkLoggerProvider and SdkMeterProvider.

Additionally, the OpenTelemetry Resource is now a bean. Resource
attributes can now be configured through properties

The resourceAttributes in OtlpProperties have been deprecated in favor
of the new one in OpenTelemetryProperties.

Closes spring-projectsgh-36544
Closes spring-projectsgh-36545
mhalbritter added a commit to mhalbritter/spring-boot that referenced this issue Jul 25, 2023
@mhalbritter
Split OpenTelemetry auto-configuration
6d14596 
The OpenTelemetry bean is now configured in the
OpenTelemetryAutoConfiguration. This method also applies
SdkLoggerProvider and SdkMeterProvider.

Additionally, the OpenTelemetry Resource is now a bean. Resource
attributes can now be configured through properties

The resourceAttributes in OtlpProperties have been deprecated in favor
of the new one in OpenTelemetryProperties.

Closes spring-projectsgh-36544
Closes spring-projectsgh-36545
@mhalbritter mhalbritter modified the milestones: 3.2.x, 3.2.0-M2 Jul 27, 2023
@mhalbritter mhalbritter mentioned this issue Sep 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhalbritter mhalbritter

Labels
theme: observability Issues related to observability type: enhancement A general enhancement
Projects
None yet
Milestone
3.2.0-M2
Development

No branches or pull requests
1 participant
@mhalbritter