Nested jar URLs can not be resolved if the path contains spaces #39675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
URL can contains empty spaced encoded as %20, so it should be decoded before passing it to NestedLocation. NestedLocation expects file system path which should not contain URL encoded values. Closes spring-projectsgh-39655
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: regression
This was referenced Feb 22, 2024
philwebb
pushed a commit
that referenced
this pull request
Feb 22, 2024
URL can contains empty spaced encoded as %20, so it should be decoded before passing it to NestedLocation. NestedLocation expects file system path which should not contain URL encoded values. See gh-39675
philwebb
added a commit
that referenced
this pull request
Feb 22, 2024
* pr/39675: Polish 'Decode URL content before passing it to NestedLocation.parse' Decode URL content before passing it to NestedLocation.parse Closes gh-39675
|
Thanks very much @slovi! Perfect timing as I managed to squeeze this in just before tomorrows releases. |
|
That is great, thanks a lot! |
scottfrederick
changed the title
ndwnu
pushed a commit
to ndwnu/nls-routing-map-matcher
that referenced
this pull request
Apr 10, 2024
…ot-starter-parent to v3.2.3 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.springframework.boot:spring-boot-starter-parent](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | parent | patch | `3.2.2` -> `3.2.3` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the logs for more information. --- ### Release Notes <details> <summary>spring-projects/spring-boot (org.springframework.boot:spring-boot-starter-parent)</summary> ### [`v3.2.3`](https://github.com/spring-projects/spring-boot/releases/tag/v3.2.3) [Compare Source](spring-projects/spring-boot@v3.2.2...v3.2.3) ####⚠️ Noteworthy - This release upgrades to Hibernate 6.4.4.Final. While it contains a number of valuable bug fixes, it does not work correctly in a native image. It you are using GraalVM, Hibernate should be temporarily downgraded to 6.4.2.Final using the `hibernate.version` property. #### 🐞 Bug Fixes - Nested jar URLs can not be resolved if the path contains spaces [#​39675](spring-projects/spring-boot#39675) - Image building runs for a long time when a long image name is used and the tag contains an illegal character [#​39638](spring-projects/spring-boot#39638) - Banner printing doesn't respect set charset [#​39621](spring-projects/spring-boot#39621) - "micrometer.observations.\*" configuration properties should be "management.observations.\*" [#​39600](spring-projects/spring-boot#39600) - Metadata reading during configuration class parsing uses the default resource loader rather than the application's resource loader [#​39598](spring-projects/spring-boot#39598) - Several gson properties, including spring.gson.disable-html-escaping, do not behave correctly when set to false [#​39524](spring-projects/spring-boot#39524) - Property placeholders aren't resolved when configuration property binding creates a Map from a property value using a converter [#​39515](spring-projects/spring-boot#39515) - Gradle plugin allows the use of Gradle 7.4 but the documented and tested minimum is 7.5 [#​39513](spring-projects/spring-boot#39513) - WebFlux auto-configuration should only configure the blocking executor when virtual threads are enabled [#​39469](spring-projects/spring-boot#39469) - TestcontainersPropertySource assertion has typo [#​39449](spring-projects/spring-boot#39449) - Webflux actuator endpoints respond with 500 when a parameter is missing [#​39444](spring-projects/spring-boot#39444) - NoSuchMethod error when using the non-shaded Pu...
ndwlocatieservices
added a commit
to ndwnu/nls-routing-map-matcher
that referenced
this pull request
Apr 16, 2024
…ot-starter-parent to v3.2.3 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.springframework.boot:spring-boot-starter-parent](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | parent | patch | `3.2.2` -> `3.2.3` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the logs for more information. --- ### Release Notes <details> <summary>spring-projects/spring-boot (org.springframework.boot:spring-boot-starter-parent)</summary> ### [`v3.2.3`](https://github.com/spring-projects/spring-boot/releases/tag/v3.2.3) [Compare Source](spring-projects/spring-boot@v3.2.2...v3.2.3) ####⚠️ Noteworthy - This release upgrades to Hibernate 6.4.4.Final. While it contains a number of valuable bug fixes, it does not work correctly in a native image. It you are using GraalVM, Hibernate should be temporarily downgraded to 6.4.2.Final using the `hibernate.version` property. #### 🐞 Bug Fixes - Nested jar URLs can not be resolved if the path contains spaces [#​39675](spring-projects/spring-boot#39675) - Image building runs for a long time when a long image name is used and the tag contains an illegal character [#​39638](spring-projects/spring-boot#39638) - Banner printing doesn't respect set charset [#​39621](spring-projects/spring-boot#39621) - "micrometer.observations.\*" configuration properties should be "management.observations.\*" [#​39600](spring-projects/spring-boot#39600) - Metadata reading during configuration class parsing uses the default resource loader rather than the application's resource loader [#​39598](spring-projects/spring-boot#39598) - Several gson properties, including spring.gson.disable-html-escaping, do not behave correctly when set to false [#​39524](spring-projects/spring-boot#39524) - Property placeholders aren't resolved when configuration property binding creates a Map from a property value using a converter [#​39515](spring-projects/spring-boot#39515) - Gradle plugin allows the use of Gradle 7.4 but the documented and tested minimum is 7.5 [#​39513](spring-projects/spring-boot#39513) - WebFlux auto-configuration should only configure the blocking executor when virtual threads are enabled [#​39469](spring-projects/spring-boot#39469) - TestcontainersPropertySource assertion has typo [#​39449](spring-projects/spring-boot#39449) - Webflux actuator endpoints respond with 500 when a parameter is missing [#​39444](spring-projects/spring-boot#39444) - NoSuchMethod error when using the non-shaded Pu...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL can contains empty spaced encoded as %20, so it should be decoded before passing it to NestedLocation. NestedLocation expects file system path which should not contain URL encoded values.
Closes gh-39655