Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread name prefix is not always set when using virtual threads #39958

Conversation

MazizEsa
Copy link

@MazizEsa MazizEsa commented Mar 17, 2024

Currently the thread names are missing for rabbit listener, pulsars' consumer and task executor.
This PR added the thread names for mentioned components following convention specified in other autoconfigs via RabbitAnnotationDrivenConfiguration and PulsarAutoconfiguration.

Tests are added as well to check the threads names are specified when threads are created (via java.util.concurrent.ThreadFactory#newThread) through the factory.

Request / bug ticket, #39748

@MazizEsa
Copy link
Author

cc. @mhalbritter @scottfrederick

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 17, 2024
@mhalbritter mhalbritter self-assigned this Mar 18, 2024
@mhalbritter mhalbritter changed the title Issue 39748 Added threadname for virtual thread rabbit and pulsar Thread name prefix is not always set when using virtual threads Mar 18, 2024
@mhalbritter mhalbritter added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 18, 2024
@mhalbritter mhalbritter added this to the 3.2.x milestone Mar 18, 2024
mhalbritter pushed a commit that referenced this pull request Mar 18, 2024
@mhalbritter
Copy link
Contributor

Thanks @MazizEsa! I've polished your changes a bit in 09652cb.

@mhalbritter mhalbritter modified the milestones: 3.2.x, 3.2.4 Mar 18, 2024
@MazizEsa
Copy link
Author

I see. You guys prefer that way. Got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants