Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine CDS how-to guide #41464

Closed
wants to merge 1 commit into from

Conversation

sdeleuze
Copy link
Contributor

As explained in gh-41348, the BP_SPRING_AOT_ENABLED flag should not be promoted as it can't work by design with our current support when combined with CDS for various use cases and provides little added value as the same behavior can be achieved by adding -Dspring.aot.enabled=true to JAVA_TOOL_OPTIONS and CDS_TRAINING_JAVA_TOOL_OPTIONS.

As explained in spring-projectsgh-41348, the BP_SPRING_AOT_ENABLED flag should
not be promoted as it can't work by design with our current
support when combined with CDS for various use cases and provides
little added value as the same behavior can be achieved by adding
-Dspring.aot.enabled=true to JAVA_TOOL_OPTIONS and
CDS_TRAINING_JAVA_TOOL_OPTIONS.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 12, 2024
@wilkinsona wilkinsona added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 12, 2024
@wilkinsona wilkinsona added this to the 3.3.x milestone Jul 12, 2024
@wilkinsona wilkinsona self-assigned this Jul 12, 2024
@wilkinsona wilkinsona modified the milestones: 3.3.x, 3.3.2 Jul 12, 2024
wilkinsona pushed a commit that referenced this pull request Jul 12, 2024
As explained in gh-41348, the BP_SPRING_AOT_ENABLED flag should
not be promoted as it can't work by design with our current
support when combined with CDS for various use cases and provides
little added value as the same behavior can be achieved by adding
-Dspring.aot.enabled=true to JAVA_TOOL_OPTIONS and
CDS_TRAINING_JAVA_TOOL_OPTIONS.

See gh-41464
wilkinsona added a commit that referenced this pull request Jul 12, 2024
* gh-41464:
  Refine CDS how-to guide

Closes gh-41464
@wilkinsona
Copy link
Member

Thank you, @sdeleuze.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants