Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContainerConnectionDetails should inherit qualifiers from Container bean #42978

Closed
wants to merge 1 commit into from
Closed

ContainerConnectionDetails should inherit qualifiers from Container bean #42978

wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Nov 4, 2024

@quaff quaff mentioned this pull request Nov 4, 2024
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 4, 2024
@wilkinsona
Copy link
Member

Thanks, @quaff, but it feels like we're rushing again. I don't think we can take this approach as it may not be desirable for the container beans to be qualified. It also doesn't consider the case where @ServiceConnection is used on a field. I've opened #42979 so that we can do some design work in due course.

@wilkinsona wilkinsona closed this Nov 4, 2024
@wilkinsona wilkinsona added status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quaff @wilkinsona @spring-projects-issues