Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Spring 4 #77

Closed
odrotbohm opened this issue May 21, 2014 · 3 comments
Closed

Upgrade to Spring 4 #77

odrotbohm opened this issue May 21, 2014 · 3 comments
Assignees

Comments

@odrotbohm
Copy link
Member

So far, Spring Data modules have required the latest Spring 3.2.x version as dependency and the modules integrate with new features available in Spring 4 in a lenient way.

However, an upgrade to Spring 4 would allow us to remove a few of these lenient checks for the Spring 4 presence and make use of new features like the @Conditional annotation, better JDK 8 integration etc. With Spring 4.1 to be released by the time we're going to GA with the Evans release train, we'd still adhere to the "compatibility with the last but one Spring version" mantra.

Moving to Spring 4 as new baseline would also mean that the service releases for the current Spring Data Dijkstra release trains are probably maintained for a longer time than we used to do for Babbage or Codd. Still, all major new features would go into a Spring 4 based Evans.

In case you have objections to this move, feel free to elaborate on them. A plain -1 is not a convincing argument. Wouldn't mind to get supporting comments as well.

@odrotbohm odrotbohm added this to the 1.5 M1 milestone May 21, 2014
@odrotbohm odrotbohm self-assigned this May 21, 2014
@dharrigan
Copy link

+1. I'm (mostly) always in favour of moving ahead with newer codebases and working with better implementations. Spring 4 would be a marvelous baseline and would encourage more people to migrate upwards thus gaining the advantages that this brings.

@odrotbohm
Copy link
Member Author

Spring 4 would be a marvelous baseline and would encourage more people to migrate upwards thus gaining the advantages that this brings.

Thanks, David. A key idea behind the upgrade is to create these incentives. Also, we think that if people are able to upgrade to a latest version of Spring Data, they should be also upgrade to a Spring 4 version. I know, there might be political and organization issues involved. That's why - assuming we eventually follow the suggestion here - we're going to extend the maintenance period for the current Dijkstra release to give users more time to upgrade.

@geoand
Copy link

geoand commented May 24, 2014

+1 I'm also almost always in favor of using the newer implementations! My experience with upgrading some of our current systems to Spring 4 was pretty painless, so I don't think that technical issues are really a matter in such an upgrade.

odrotbohm added a commit that referenced this issue Jul 1, 2014
Upgraded to Spring 4.0.5.RELEASE as baseline for Spring Data builds. Removed spring32-next profile as well as the spring4 one. Added a dedicated spring41-next profile to be able to build against Spring 4.1 snapshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants