Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for jMolecules' Association type. #2316

Closed
wants to merge 1 commit into from
Closed

Support for jMolecules' Association type. #2316

wants to merge 1 commit into from

Conversation

odrotbohm
Copy link
Member

We no recognize properties of type org.jmolecules.ddd.types.Association as associations in our PersistentProperty model.

Also, we now register JMolecules' Converter implementations for Association and Identifier in CustomConversions so that they can persisted like their embedded primitive value out of the box.

Fixes #2315.

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@odrotbohm
Support for jMolecules' Association type.
2f64304 
We no recognize properties of type org.jmolecules.ddd.types.Association as associations in our PersistentProperty model.

Also, we now register JMolecules Converter implementations for Association and Identifier in CustomConversions so that they can persisted like their embedded primitive value out of the box.

Fixes #2315.
mp911de pushed a commit that referenced this pull request Mar 1, 2021
@odrotbohm @mp911de
Support for jMolecules' Association type.
6b0292c 
We no recognize properties of type org.jmolecules.ddd.types.Association as associations in our PersistentProperty model.

Also, we now register JMolecules Converter implementations for Association and Identifier in CustomConversions so that they can persisted like their embedded primitive value out of the box.

Fixes #2315.
Original pull request: #2316.
@mp911de
Copy link
Member

mp911de commented Mar 1, 2021

That's merged now.

@mp911de mp911de closed this Mar 1, 2021
@mp911de mp911de deleted the issue/2315-jmolecules-association branch March 1, 2021 14:26
@mp911de mp911de added the type: enhancement A general enhancement label Mar 1, 2021
@mp911de mp911de added this to the 2.5 RC1 (2021.0.0) milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.5 M5 (2021.0.0)
Development

Successfully merging this pull request may close these issues.

Support for jMolecules' Association type
2 participants
@odrotbohm @mp911de