Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add matched_queries field in SearchHit [DATAES-979] #1514

Closed
spring-projects-issues opened this issue Nov 19, 2020 · 3 comments · Fixed by #1722
Closed

Add matched_queries field in SearchHit [DATAES-979] #1514

spring-projects-issues opened this issue Nov 19, 2020 · 3 comments · Fixed by #1722
Labels
in: core Issues in core support type: enhancement A general enhancement

Comments

@spring-projects-issues
Copy link

Farooq Ahmad Khan opened DATAES-979 and commented

org.elasticsearch.search.SearchHit returns a field named matched_queries but the org.springframework.data.elasticsearch.core.SearchHit does not hold this value. We need this value to be added in the spring data elasticsearch

No further details from DATAES-979
@spring-projects-issues
Copy link
Author

sothawo commented

Thanks for this; as Mark wrote on Gitter, target your PR to the master branch

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: core Issues in core support labels Dec 31, 2020
@mdgilene
Copy link
Contributor

Any update on this? Our team was in the process of moving to spring data ES when I discovered we weren't able to access our named queries in the results. Pretty big blocker for us at the moment.

@sothawo
Copy link
Collaborator

sothawo commented Feb 17, 2021

No. There never was a PR opened to address this, so it is still an open issue.

mdgilene added a commit to mdgilene/spring-data-elasticsearch that referenced this issue Mar 5, 2021
@mdgilene
Add matched_queries fied to SearchHit.
6f0d8b1 
Closes spring-projects#1514
@mdgilene mdgilene mentioned this issue Mar 5, 2021
Merged
5 tasks
mdgilene added a commit to mdgilene/spring-data-elasticsearch that referenced this issue Mar 5, 2021
@mdgilene
Add matched_queries field to SearchHit.
7cf90ae 
Closes spring-projects#1514
sothawo pushed a commit that referenced this issue Mar 11, 2021
@mdgilene
Add matched_queries field to SearchHit.
4dc8b25 
Original Pull Request #1722 
Closes #1514
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: core Issues in core support type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add matched_queries field to SearchHit. mdgilene/spring-data-elasticsearch
3 participants
@sothawo @spring-projects-issues @mdgilene