Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for point_in_time search API #1684

Closed
sothawo opened this issue Feb 11, 2021 · 10 comments · Fixed by #2273
Closed

Add support for point_in_time search API #1684

sothawo opened this issue Feb 11, 2021 · 10 comments · Fixed by #2273
Assignees
Labels
type: enhancement A general enhancement

Comments

@sothawo
Copy link
Collaborator

sothawo commented Feb 11, 2021

Spring Data Elasticsearch should support the point in time (PIT) API.

This is needed together with search_after (#1143) to redesign paging through large result sets, which currently is done with the scroll API, but Elasticsearch recommends using search_after and pit.

@mateuszwinnicki
Copy link

As search_after is already in repo, can you tell when PIT will be also supported?

@sothawo
Copy link
Collaborator Author

sothawo commented Mar 24, 2021

No. I'm currently working on a different issue. This will probably be one of the next issues to address.

Keep in mind that Spring Data Elasticsearch is a community maintained project, I am doing this as well in my private time after work, and so the resources are limited.

@mateuszwinnicki
Copy link

Sure, I know that :) thanks

@sothawo sothawo added status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-feedback We need additional information before we can continue labels Apr 28, 2021
@sothawo sothawo self-assigned this May 15, 2021
@sothawo
Copy link
Collaborator Author

sothawo commented May 15, 2021

The Elasticsearch RestHighLevelClient does not yet (version 7.12.1) support the calls to open or close point in time. This was just recently merged into Elasticsearch master (elastic/elasticsearch#70593).
We have to wait for this to be available in the libraries.

@sothawo sothawo removed their assignment May 15, 2021
@sothawo sothawo added the status: blocked An issue that's blocked on an external project change label May 15, 2021
@xhaggi
Copy link
Contributor

xhaggi commented Jul 20, 2021

This is supported since version 7.14 of the Java client.

https://www.elastic.co/guide/en/elasticsearch/client/java-rest/7.14/java-rest-high-point-in-time.html

@mateuszwinnicki
Copy link

When 7.14 will be released? I can't find any dates unfortunately

@sothawo
Copy link
Collaborator Author

sothawo commented Jul 20, 2021

7.14 is not released yet. When it will be, I don't know, only Elasticsearch knows that.

@xhaggi
Copy link
Contributor

xhaggi commented Jul 20, 2021

My comment was only meant as an indication of when this problem might be resolved.

@sothawo sothawo removed the status: blocked An issue that's blocked on an external project change label Sep 17, 2021
@AntonLGVS
Copy link
Contributor

Version 7.15 has been released. What do you think can unlock the issue? ElasticSearch releases

@sothawo
Copy link
Collaborator Author

sothawo commented Dec 4, 2021

I am currently working on integrating the new Elasticsearch client (which is not released yet from Elasticsearch ) as an alternative to the current RestHighLevelClient. This will be the main change in 4.4. Adding new features will be done after this change/migratin, so it might take some more time.

@sothawo sothawo self-assigned this Aug 15, 2022
@sothawo sothawo added the status: worked on a contributor is working on this issue label Aug 15, 2022
sothawo added a commit that referenced this issue Aug 17, 2022
Original Pull Request #2273
Closes #1684
@sothawo sothawo removed the status: worked on a contributor is working on this issue label Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants