Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SearchTemplate for reactive client #1725

Closed
bilak opened this issue Mar 11, 2021 · 1 comment · Fixed by #1726
Closed

Add support for SearchTemplate for reactive client #1725

bilak opened this issue Mar 11, 2021 · 1 comment · Fixed by #1726
Labels
type: enhancement A general enhancement
Milestone
4.2 M5 (2021.0.0)

Comments

@bilak
Copy link
Contributor

bilak commented Mar 11, 2021

Hello,
it would be nice to be able to extend DefaultReactiveElasticsearchClient when it's needed to write some custom queries. For example now I'd like to implement search template however it's not that easy because of private methods sendRequest. Could we change those to protected instead of private?

Or is there any other extension point that I've missed? I'd like to use search templates.

Thanks
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 11, 2021
@sothawo sothawo added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 11, 2021
@sothawo
Copy link
Collaborator

sothawo commented Mar 11, 2021

I think we could make the three sendRequest() method protected. Although the better solution would be to add search template support by submitting a PR ;-)

@bilak bilak changed the title Extension point for DefaultReactiveElasticsearchClient Add support for SearchTemplate Mar 14, 2021
bilak added a commit to bilak/spring-data-elasticsearch that referenced this issue Mar 14, 2021
@bilak
Added SearchTemplate support for reactive client
655b2dd 
Closes spring-projects#1725
@bilak bilak mentioned this issue Mar 14, 2021
Merged
5 tasks
@sothawo sothawo changed the title Add support for SearchTemplate Add support for SearchTemplate for reactive cient Mar 16, 2021
@sothawo sothawo changed the title Add support for SearchTemplate for reactive cient Add support for SearchTemplate for reactive client Mar 16, 2021
sothawo pushed a commit that referenced this issue Mar 16, 2021
@bilak
Added SearchTemplate support for reactive client
005d6a4 
Original Pull Request #1726
Closes #1725
@sothawo sothawo added this to the 4.2 M5 (2021.0.0) milestone Mar 16, 2021
@sothawo sothawo mentioned this issue Aug 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
4.2 M5 (2021.0.0)
Development

Successfully merging a pull request may close this issue.

Added SearchTemplate support for reactive client bilak/spring-data-elasticsearch
3 participants
@bilak @sothawo @spring-projects-issues