-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search with MoreLikeThisQuery should use Pageable. #1787
Labels
type: bug
A general bug
Milestone
Comments
spring-projects-issues
added
the
status: waiting-for-triage
An issue we've not yet triaged
label
Apr 23, 2021
sothawo
changed the title
searchSimilar page not work
`org.springframework.data.elasticsearch.core.SearchOperations#search(org.springframework.data.elasticsearch.core.query.MoreLikeThisQuery, java.lang.Class<T>, org.springframework.data.elasticsearch.core.mapping.IndexCoordinates)
Apr 24, 2021
sothawo
changed the title
`org.springframework.data.elasticsearch.core.SearchOperations#search(org.springframework.data.elasticsearch.core.query.MoreLikeThisQuery, java.lang.Class<T>, org.springframework.data.elasticsearch.core.mapping.IndexCoordinates)
Apr 24, 2021
SearchOperations.search(MoreLikeThisQuery, Class<T>, IndexCoordinates)
should use Pageable
from the query
sothawo
added
type: bug
A general bug
and removed
status: waiting-for-triage
An issue we've not yet triaged
labels
Apr 24, 2021
sothawo
changed the title
Search with MoreLikeThisQuery uses Pageable.
Apr 26, 2021
SearchOperations.search(MoreLikeThisQuery, Class<T>, IndexCoordinates)
should use Pageable
from the query
sothawo
changed the title
Search with MoreLikeThisQuery uses Pageable.
Search with MoreLikeThisQuery should use Pageable.
Apr 26, 2021
sothawo
added a commit
that referenced
this issue
Apr 26, 2021
sothawo
added a commit
that referenced
this issue
Apr 26, 2021
implemented in main branch and backported to 4.2.x, 4.1.x and 4.0.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Step 1:
Step 2: Look into
<T> SearchHits<T> search(MoreLikeThisQuery query, Class<T> clazz, IndexCoordinates index);
:Step 3: It seems no problem, then look into
requestFactory.moreLikeThisQueryBuilder(query, index);
:Ok, you can see MoreLikeThisQuery's pageable property is missing, I found this issue in the 3.x version, and it still exists in the 4.x version.
In step 2, modify below
to
can fix it.
The text was updated successfully, but these errors were encountered: