Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Elasticsearch 7.14. #1892

Closed
sothawo opened this issue Aug 3, 2021 · 4 comments · Fixed by #1933
Closed

Upgrade to Elasticsearch 7.14. #1892

sothawo opened this issue Aug 3, 2021 · 4 comments · Fixed by #1933
Assignees
Labels
type: task A general task

Comments

@sothawo
Copy link
Collaborator

sothawo commented Aug 3, 2021

Note: putting this on hold as 7.14. adds the client compatibility check and thus it prevents from testing against Opensearch - at least as long as there is no Opensearch client

@sothawo sothawo added the type: task A general task label Aug 3, 2021
@sothawo sothawo self-assigned this Aug 9, 2021
@sothawo sothawo added the status: on-hold We cannot start working on this issue yet label Aug 9, 2021
@sdavids13
Copy link

Came here to see what was going to happen to this project now that Elastic Co. is basically trying to kill off anything that isn't strictly controlled by them. I'm glad to see that you won't be upgrading and thus breaking anyone using Opensearch. I wanted to raise awareness that AWS is now intending on maintaining an Open Source client that will be compatible with both platforms as announced here: https://aws.amazon.com/blogs/opensource/keeping-clients-of-opensearch-and-elasticsearch-compatible-with-open-source/

Not sure what the ETA is on this one, but wondering if the ticket name/description should be to upgrade to the OpenSearch Client?

@sothawo
Copy link
Collaborator Author

sothawo commented Aug 11, 2021

No. Spring Data Elasticsearch primarily target Elasticsearch.

We currently change the internal architecture to be able to use the new Elasticsearch Client once it is available and to be able to provide a client based on the Elasticsearch 7.10.2 code, which allows Spring Data Elasticsearch to target an Opensearch cluster - although when checking https://opensearch.org/docs/clients/index/ (as of today) the recommended version is 7.13.4

If there will be an official release of the RestHighLevelClient from Opensearch in a maven repository, we will use this to replace the Elasticsearch 7.10.2/7.13.4 based client.

If there will be an official fork and release of the new client - which is mentioned in the list you linked - it might make sense to think about an implementation of Spring Data Elasticsearch that allows choosing either the one or the other

Currently there is no Opensearch client. And as I wrote, if there will be one, we will add this as a possible alternative.

@rursprung
Copy link

rursprung commented Sep 2, 2021

If there will be an official release of the RestHighLevelClient from Opensearch in a maven repository, we will use this to replace the Elasticsearch 7.10.2/7.13.4 based client.

i believe this has now been released: https://repo1.maven.org/maven2/org/opensearch/client/opensearch-rest-high-level-client/1.0.0/
see also opensearch-project/opensearch-build#20

@sothawo
Copy link
Collaborator Author

sothawo commented Sep 2, 2021

Thank you for this information. This will be definitely helpful to have an org.opensearch client when restructuring to support multiple client implementations without having name/package clashes.

@sothawo sothawo added this to To do in what's up next? Sep 10, 2021
@sothawo sothawo moved this from To do to In progress in what's up next? Sep 14, 2021
@sothawo sothawo removed the status: on-hold We cannot start working on this issue yet label Sep 14, 2021
@sothawo sothawo added this to the 4.3 M3 (2021.1.0) milestone Sep 14, 2021
what's up next? automation moved this from In progress to Done Sep 14, 2021
sothawo added a commit that referenced this issue Sep 14, 2021
Original Pull Request #1933 
Closes #1892
@sothawo sothawo changed the title Upgrade to Elasticsearch 7.14.0 Upgrade to Elasticsearch 7.14. Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants