Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @QueryAnnotation to @Query #1938

Closed
Stexxen opened this issue Sep 21, 2021 · 0 comments · Fixed by #1939
Closed

Add @QueryAnnotation to @Query #1938

Stexxen opened this issue Sep 21, 2021 · 0 comments · Fixed by #1939
Labels
type: enhancement A general enhancement

Comments

@Stexxen
Copy link
Contributor

Stexxen commented Sep 21, 2021

Without the @QueryAnnotation on the org.springframework.data.elasticsearch.annotations.Query IntelliJ believes it needs to parse the method name to see if the parameters exist.
i.e.

image

I initially raised this as a problem for JetBeans here https://youtrack.jetbrains.com/issue/IDEA-278060 but as you can see from the comment https://youtrack.jetbrains.com/issue/IDEA-278060#focus=Comments-27-5190643.0-0

works ok for all @query annotations that are annotated with @QueryAnnotation (org.springframework.data.jpa.repository.Query, org.springframework.data.mongodb.repository.Query, org.springframework.data.neo4j.repository.query.Query, org.springframework.data.cassandra.repository.Query, ...)

Doesn't work for annotations that are not @QueryAnnotation-s: org.springframework.data.elasticsearch.annotations.Query, org.springframework.data.solr.repository.Query, org.apache.deltaspike.data.api.Query,...)

I attempted to create a PR myself, but could not get all the integration tests to pass before I made the change.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 21, 2021
sothawo pushed a commit that referenced this issue Sep 21, 2021
@sothawo sothawo added this to the 4.3 RC1 (2021.1.0) milestone Sep 21, 2021
@sothawo sothawo added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants