Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractElasticsearchTemplate.searchForStream use Query scrolltime #1950

Closed
Stexxen opened this issue Oct 2, 2021 · 1 comment · Fixed by #1951
Closed

AbstractElasticsearchTemplate.searchForStream use Query scrolltime #1950

Stexxen opened this issue Oct 2, 2021 · 1 comment · Fixed by #1951
Labels
status: waiting-for-triage An issue we've not yet triaged

Comments

@Stexxen
Copy link
Contributor

Stexxen commented Oct 2, 2021

When using searchForStream in ElasticSearchOperations the scroll time is always set to 60 seconds, ignoring any setting made in the Query

i.e.

  NativeSearchQuery query = ....
  query.setScrollTime(Duration.of(120, ChronoUnit.SECONDS));

  try (SearchHitsIterator<Thing> searchHitsIterator = opTemplate.searchForStream(query, Thing.class)) {

Will always set scroll=60000ms in the initial and subsequent queries to elastic even though a different scroll time has been specified.

@Stexxen Stexxen changed the title searchForStream ignoring any Query.scrolltime setting. defaults to 60 seconds searchForStream ignoring Query.scrolltime setting. defaults to 60 seconds Oct 2, 2021
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 2, 2021
sothawo pushed a commit that referenced this issue Oct 3, 2021
@sothawo sothawo changed the title searchForStream ignoring Query.scrolltime setting. defaults to 60 seconds AbstractElasticsearchTemplate.searchForStream use Query scrolltime Oct 3, 2021
@sothawo sothawo added this to the 4.3 RC1 (2021.1.0) milestone Oct 3, 2021
@sothawo
Copy link
Collaborator

sothawo commented Oct 3, 2021

thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants