Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Data Envers Documentation Only Contains General Spring Data Information #61

Closed
nbrooks opened this issue Oct 12, 2016 · 6 comments
Assignees
Labels
type: documentation A documentation update

Comments

@nbrooks
Copy link

nbrooks commented Oct 12, 2016

The Spring Data Envers Documentation Link in the README file appears to be showing only the general Spring Data Commons information, and no specific details about working with spring-data-envers. The sections are all related to general CrudRepository usage, and 'Envers' only appears in the page header ('revision' doesn't appear anywhere in that document). This is also an issue for older versions of the documentation. I'm assuming that the links are just referring to the wrong documents somehow, so hopefully this is an easy fix. Apologies if this isn't the correct place to submit this feedback.

@kalexmills
Copy link

It has been three years, and the documentation is still non-existent. Why is this project still part of the spring framework?

@scordio
Copy link
Contributor

scordio commented Feb 1, 2021

I am happy to help to improve the docs if needed.

@schauder
Copy link
Contributor

schauder commented Feb 1, 2021

@scordio Help is always welcome.

@schauder schauder added type: documentation A documentation update and removed for: team-attention An issue we need to discuss as a team to make progress status: waiting-for-triage An issue we've not yet triaged labels Feb 1, 2021
@schauder schauder self-assigned this Feb 1, 2021
@scordio
Copy link
Contributor

scordio commented Feb 1, 2021

@schauder may I ask for some pointers about the documentation source files? https://github.com/spring-projects/spring-data-envers/tree/master/src/main/asciidoc seems to be empty so I'm wondering where they are actually stored.

@schauder
Copy link
Contributor

schauder commented Feb 1, 2021

@scordio Sure.

https://github.com/spring-projects/spring-data-envers/tree/master/src/main/asciidoc isn't empty, there is an index.adoc which is the correct place to start.

We typically create a separate file for the main documentation which then gets included. The canonical name would be envers.adoc in the same directory.

You might want to take a look in the corresponding source files in other projects, for example Spring Data JDBC https://github.com/spring-projects/spring-data-jdbc/tree/master/src/main/asciidoc

@scordio
Copy link
Contributor

scordio commented Feb 1, 2021

Thanks and sorry, I thought I opened that file 🤦

schauder added a commit that referenced this issue Feb 18, 2021
schauder added a commit that referenced this issue Feb 18, 2021
Adding myself as author

See #61
@schauder schauder assigned mp911de and unassigned schauder Feb 18, 2021
mp911de added a commit that referenced this issue Feb 25, 2021
Reformat code. Add link to Envers. Consistently use template variables.

See #61
Original pull request: #279.
mp911de added a commit that referenced this issue Feb 25, 2021
Reformat code. Add link to Envers. Consistently use template variables.

See #61
Original pull request: #279.
mp911de added a commit that referenced this issue Feb 25, 2021
Reformat code. Add link to Envers. Consistently use template variables.

See #61
Original pull request: #279.
@mp911de mp911de added this to the 2.3.8 (Neumann SR8) milestone Feb 25, 2021
schauder pushed a commit that referenced this issue Mar 8, 2021
Edited for grammar, punctuation, and usage.

Original pull request #283
Related tickets #61
schauder pushed a commit that referenced this issue Mar 8, 2021
Edited for grammar, punctuation, and usage.

Original pull request #283
Related tickets #61
schauder pushed a commit that referenced this issue Mar 8, 2021
Edited for grammar, punctuation, and usage.

Original pull request #283
Related tickets #61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants