Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve handling of ESCAPE clause with LIKE queries on EclipseLink #2955

Closed
gregturn opened this issue May 15, 2023 · 3 comments
Closed

Resolve handling of ESCAPE clause with LIKE queries on EclipseLink #2955

gregturn opened this issue May 15, 2023 · 3 comments
Assignees
@gregturn
Labels
in: query-parser Everything related to parsing JPQL or SQL in: repository Repositories abstraction type: regression A regression from a previous release
Milestone
3.1.1 (2023.0.1)

Comments

@gregturn
Copy link
Contributor

For some reason, EclipseLink doesn't handle the LIKE queries with SpEL expressions and the ESCAPE character. For Hibernate, this involved a change to the HQL grammer.

However for EclipseLink, this may be a different issue.
@gregturn gregturn self-assigned this May 15, 2023
@gregturn gregturn added in: repository Repositories abstraction in: query-parser Everything related to parsing JPQL or SQL labels May 15, 2023
@gregturn gregturn added this to the 3.2 M1 (2023.1.0) milestone May 15, 2023
@gregturn
Copy link
Contributor Author

Related: #2954

@gregturn
Copy link
Contributor Author

Looks like this is HSQL's fault. When I run the same tests against H2, it runs just fine.

gregturn added a commit that referenced this issue May 17, 2023
@gregturn
Resolve handling of ESCAPE clause with LIKE queries on EclipseLink.
86a69e8 
Migrate tests to H2 to verify LIKE with ESCAPE works properly on EclipseLink with Spring Data JPA.

See #2955
gregturn added a commit that referenced this issue May 17, 2023
@gregturn
Resolve handling of ESCAPE clause with LIKE queries on EclipseLink.
12bb259 
Migrate tests to H2 to verify LIKE with ESCAPE works properly on EclipseLink with Spring Data JPA.

See #2955
@gregturn gregturn linked a pull request May 17, 2023 that will close this issue
Handle LIKE with ESCAPE clause in Hibernate and EclipseLink #2956
Closed
gregturn added a commit that referenced this issue May 17, 2023
@gregturn
Resolve handling of ESCAPE clause with LIKE queries on EclipseLink.
14bd7ef 
Migrate tests to H2 to verify LIKE with ESCAPE works properly on EclipseLink with Spring Data JPA.

See #2955
Original Pull Request: #2956.
@gregturn
Copy link
Contributor Author

This fix should be candidate for backporting to supported versions of Spring Data JPA.

gregturn added a commit that referenced this issue May 30, 2023
@gregturn
Resolve handling of ESCAPE clause with LIKE queries on EclipseLink.
635997d 
Migrate tests to H2 to verify LIKE with ESCAPE works properly on EclipseLink with Spring Data JPA.

See #2955
Original Pull Request: #2956.
@mp911de mp911de changed the title Resolve handling of ESCAPE clause with LIKE queries on EclipseLink. Resolve handling of ESCAPE clause with LIKE queries on EclipseLink May 31, 2023
@mp911de mp911de added type: bug A general bug type: regression A regression from a previous release and removed type: bug A general bug labels May 31, 2023
mp911de pushed a commit that referenced this issue May 31, 2023
@gregturn @mp911de
Resolve handling of ESCAPE clause with LIKE queries on EclipseLink.
1f28c61 
Migrate tests to H2 to verify LIKE with ESCAPE works properly on EclipseLink with Spring Data JPA.

Resolves #2955
Original Pull Request: #2956.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregturn gregturn

Labels
in: query-parser Everything related to parsing JPQL or SQL in: repository Repositories abstraction type: regression A regression from a previous release
Projects
None yet
Milestone
3.1.1 (2023.0.1)
Development

Successfully merging a pull request may close this issue.

Handle LIKE with ESCAPE clause in Hibernate and EclipseLink spring-projects/spring-data-jpa
2 participants
@gregturn @mp911de