Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling collections and map types before running an element converter #3912

Open
wants to merge 5 commits into
base: 3.4.x
Choose a base branch
from

Commits on Dec 10, 2021

  1. Handling collections and map types before running an element converter

    When the custom conversions are checked before collection and map converters, it is not possible to use custom converters for lists and maps.
    If a custom converter for a list or a map is defined, it is executed here and not from within the `collectionConverter` where it should be executed.
    So I think collections and maps should be handled beforehand.
    Maybe lines 2064-2066 might not be needed ad all as this case is covered with line 2081
    nexx512 committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    860f742 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2021

  1. Added tests

    nexx512 committed Dec 12, 2021
    Configuration menu
    Copy the full SHA
    da1ab9a View commit details
    Browse the repository at this point in the history
  2. Tests extended

    nexx512 committed Dec 12, 2021
    Configuration menu
    Copy the full SHA
    eab7b67 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2021

  1. Added support to convert to custom list and map implementations after…

    … the elements of a list or map have been converted to be able to use `Converter<List<?>, List<?>>` and `Converter<Map<?, ?>, Map<?, ?>>` Converters.
    nexx512 committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    b35cf7a View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2021

  1. Added missing dependency for tests

    nexx512 committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    9990280 View commit details
    Browse the repository at this point in the history