Fixed the bug, a null able list does not work #4734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is a nullable list with values, the implementation should check it instead of wrapping the nullable list (even if it has values) into another newly created list by the Criteria class.
if (!filter.ids.isNullOrEmpty()) criteria.and("id").`in`(filter.ids)
-> {"id" : { "$in" : [["667e8b8af76f17213e4d4280"]]}}
if (!filter.ids.isNullOrEmpty()) criteria.and("id").`in`(filter.ids!!)
-> {"id" :{ "$in" : ["667e8b8af76f17213e4d4280"]}}
|
@sikandar Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@sikandar Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
If there is a nullable list with values, the implementation should check it instead of wrapping the nullable list (even if it has values) into another newly created list by the Criteria class.
Existing
Code: if (!filter.ids.isNullOrEmpty()) criteria.and("id").in(filter.ids)
Output: {"id" : { "$in" : [["667e8b8af76f17213e4d4280"]]}} Wrong
Code: if (!filter.ids.isNullOrEmpty()) criteria.and("id").in(filter.ids!!) Required !!
Output: {"id" :{ "$in" : ["667e8b8af76f17213e4d4280"]}} Correct
After Fix
Code: if (!filter.ids.isNullOrEmpty()) criteria.and("id").in(filter.ids) With and Without !!
Output: {"id" : { "$in" : ["667e8b8af76f17213e4d4280"]}} Correct
If there is a nullable list with values, the implementation should check it instead of wrapping the nullable list (even if it has values) into another newly created list by the Criteria class.
Existing
Code: if (!filter.ids.isNullOrEmpty()) criteria.and("id").in(filter.ids)
Output: {"id" : { "$in" : [["667e8b8af76f17213e4d4280"]]}} Wrong
Code: if (!filter.ids.isNullOrEmpty()) criteria.and("id").in(filter.ids!!) Required !!
Output: {"id" :{ "$in" : ["667e8b8af76f17213e4d4280"]}} Correct
After Fix
Code: if (!filter.ids.isNullOrEmpty()) criteria.and("id").in(filter.ids) With and Without !!
Output: {"id" : { "$in" : ["667e8b8af76f17213e4d4280"]}} Correct
You have read the Spring Data contribution guidelines.
You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
You submit test cases (unit or integration tests) that back your changes.
You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
|
Thank you for getting in touch. Please explain why you think this is necessary and provide throughout testcases for the proposed change since there's a method that accepts a As |
christophstrobl
added
status: waiting-for-feedback
This solution will be able to work with Variable Arguments |
spring-projects-issues
added
status: feedback-provided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a nullable list with values, the implementation should check it instead of wrapping the nullable list (even if it has values) into another newly created list by the Criteria class.
Existing
Code:
if (!filter.ids.isNullOrEmpty()) criteria.and("id").in(filter.ids)Output:
{"id" : { "$in" : [["667e8b8af76f17213e4d4280"]]}}WrongCode:
if (!filter.ids.isNullOrEmpty()) criteria.and("id").in(filter.ids!!)Required !!Output:
{"id" :{ "$in" : ["667e8b8af76f17213e4d4280"]}}CorrectAfter Fix
Code:
if (!filter.ids.isNullOrEmpty()) criteria.and("id").in(filter.ids)With and Without !!Output:
{"id" : { "$in" : ["667e8b8af76f17213e4d4280"]}}Correct