Feature/sort logging #4794
Closed
Feature/sort logging #4794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
Care to rebase your PR as it contains merge commits? |
spring-projects-issues
added
the
status: waiting-for-triage
mp911de
reviewed
Sep 25, 2024
| @@ -2559,8 +2561,8 @@ protected <T> T doFindOne(String collectionName, CollectionPreparer<MongoCollect | |||
| * @return the List of converted objects. | |||
| */ | |||
| protected <T> List<T> doFind(String collectionName, CollectionPreparer<MongoCollection<Document>> collectionPreparer, | |||
| Document query, Document fields, Class<T> entityClass) { | |||
| return doFind(collectionName, collectionPreparer, query, fields, entityClass, null, | |||
| Document query, Document fields, Document sort, Class<T> entityClass) { | |||
There was a problem hiding this comment.
We cannot simply change the signature of our API. With sort being an essential part for query logging, we might consider reworking QueryCursorPreparer to remove sorting from the preparer and putting it into method signatures.
There was a problem hiding this comment.
@mp911de - this PR was just to show what is the problem. The easiest way was to show what was incorrectly logged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorrect sort logging introduced on #4686.
Logging query instead of sort.
@mp911de Could you please verify ?