-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ReactiveSortingRepository support #407
Labels
type: enhancement
A general enhancement
Milestone
Comments
mp911de
pushed a commit
that referenced
this issue
Jul 23, 2020
Implements ReactiveSortingRepository on SimpleR2dbcRepository. Also changed R2dbcRepository to extend ReactiveSortingRepository and updated comments where it felt reasonable. Added a single unit test for the new method, and changed the base interface of LegoSetRepository in AbstractR2dbcRepositoryIntegrationTests for integration testing purposes. Clarify documentation on reactive repository base interfaces Adds some language calling out ReactiveSortingRepository and fixes consistency between related examples. Original pull request: #408.
mp911de
added a commit
that referenced
this issue
Jul 23, 2020
Guard find(Sort) against null values. Add author to documentation. Use ReactiveDataAccessStrategy in R2dbcEntityTemplate created in SimpleR2dbcRepository. Original pull request: #408.
mp911de
pushed a commit
that referenced
this issue
Jul 23, 2020
Implements ReactiveSortingRepository on SimpleR2dbcRepository. Also changed R2dbcRepository to extend ReactiveSortingRepository and updated comments where it felt reasonable. Added a single unit test for the new method, and changed the base interface of LegoSetRepository in AbstractR2dbcRepositoryIntegrationTests for integration testing purposes. Clarify documentation on reactive repository base interfaces Adds some language calling out ReactiveSortingRepository and fixes consistency between related examples. Original pull request: #408.
mp911de
added a commit
that referenced
this issue
Jul 23, 2020
Guard find(Sort) against null values. Add author to documentation. Use ReactiveDataAccessStrategy in R2dbcEntityTemplate created in SimpleR2dbcRepository. Original pull request: #408.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently
SimpleR2dbcRepository
only implementsReactiveCrudRepository
. It does not implement or provide the extra method defined byReactiveSortingRepository
.Modifying
SimpleR2dbcRepository
to implementReactiveSortingRepository
would allow consumers to use that interface (and its friends such asCoroutineSortingRepository
) when defining their repositories.I plan to put up a PR for this soon.
This is a follow-up from DATACMNS-1769
Thank you to @mp911de for pointing me in the right direction!
The text was updated successfully, but these errors were encountered: