Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ReactiveSortingRepository support #407

Closed
ada-waffles opened this issue Jul 21, 2020 · 0 comments
Closed

Add ReactiveSortingRepository support #407

ada-waffles opened this issue Jul 21, 2020 · 0 comments
Labels
type: enhancement A general enhancement
Milestone
1.2 M2 (2020.0.0)

Comments

@ada-waffles
Copy link
Contributor

Currently SimpleR2dbcRepository only implements ReactiveCrudRepository. It does not implement or provide the extra method defined by ReactiveSortingRepository.

Modifying SimpleR2dbcRepository to implement ReactiveSortingRepository would allow consumers to use that interface (and its friends such as CoroutineSortingRepository) when defining their repositories.

I plan to put up a PR for this soon.

This is a follow-up from DATACMNS-1769

Thank you to @mp911de for pointing me in the right direction!
@mp911de mp911de added the type: enhancement A general enhancement label Jul 22, 2020
@mp911de mp911de added this to the 1.2 M2 (2020.0.0) milestone Jul 22, 2020
mp911de pushed a commit that referenced this issue Jul 23, 2020
@ada-waffles @mp911de
#407 - Add ReactiveSortingRepository support.
4da92bd 
Implements ReactiveSortingRepository on SimpleR2dbcRepository. Also changed R2dbcRepository to extend ReactiveSortingRepository and updated comments where it felt reasonable.

Added a single unit test for the new method, and changed the base interface of LegoSetRepository in AbstractR2dbcRepositoryIntegrationTests for integration testing purposes.

Clarify documentation on reactive repository base interfaces

Adds some language calling out ReactiveSortingRepository and fixes consistency between related examples.

Original pull request: #408.
mp911de added a commit that referenced this issue Jul 23, 2020
@mp911de
#407 - Polishing.
ed63cef 
Guard find(Sort) against null values. Add author to documentation. Use ReactiveDataAccessStrategy in R2dbcEntityTemplate created in SimpleR2dbcRepository.

Original pull request: #408.
mp911de pushed a commit that referenced this issue Jul 23, 2020
@ada-waffles @mp911de
#407 - Add ReactiveSortingRepository support.
c4449be 
Implements ReactiveSortingRepository on SimpleR2dbcRepository. Also changed R2dbcRepository to extend ReactiveSortingRepository and updated comments where it felt reasonable.

Added a single unit test for the new method, and changed the base interface of LegoSetRepository in AbstractR2dbcRepositoryIntegrationTests for integration testing purposes.

Clarify documentation on reactive repository base interfaces

Adds some language calling out ReactiveSortingRepository and fixes consistency between related examples.

Original pull request: #408.
mp911de added a commit that referenced this issue Jul 23, 2020
@mp911de
#407 - Polishing.
adb878e 
Guard find(Sort) against null values. Add author to documentation. Use ReactiveDataAccessStrategy in R2dbcEntityTemplate created in SimpleR2dbcRepository.

Original pull request: #408.
@mp911de mp911de closed this as completed Jul 23, 2020
@mp911de mp911de mentioned this issue Aug 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
1.2 M2 (2020.0.0)
Development

No branches or pull requests
2 participants
@mp911de @ada-waffles