Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ZMSCORE through variadic ZSetOperations.score(K key, Object... o) and ReactiveZSetOperations #2038

Closed
4 tasks done
mp911de opened this issue Apr 19, 2021 · 0 comments
Assignees
Labels

Comments

@mp911de
Copy link
Member

mp911de commented Apr 19, 2021

Hi, this is a ideal-for-contribution issue. This means we've worked to make it more legible to folks who don't haven't contributed much to our codebase before.

Problem

Redis 6.2 introduced a new command ZMSCORE as variadic variant of ZSCORE. We want to support this command in Spring Data Redis.

Solution

Add List<Double> score(K key, Object... o) to ZSetOperations and ReactiveZSetOperations. The reactive API should return Mono<List<Double>>. Add a score(Object…) method to BoundZSetOperations and make sure to implement the methods on the classes implementing the interfaces.

Extend the reactive and imperative command interfaces ReactiveZSetCommands respective RedisZSetCommands including DefaultedRedisConnection. You will need to extend JedisClusterZSetCommands, JedisZSetCommands, and LettuceZSetCommands.

AbstractConnectionIntegrationTests is the main test class for connection-related tests.

See also https://redis.io/commands/zmscore for further information.

Steps to Fix

  • Claim this issue with a comment below and ask any clarifying questions you need
  • Set up a repository locally following the Contributing Guidelines
  • Try to fix the issue following the steps above
  • Commit your changes and start a pull request
@mp911de mp911de added type: enhancement A general enhancement theme: Redis 6.2 status: ideal-for-contribution An issue that a contributor can help us with labels Apr 19, 2021
@mp911de mp911de self-assigned this Jun 15, 2021
@mp911de mp911de removed the status: ideal-for-contribution An issue that a contributor can help us with label Jun 15, 2021
mp911de added a commit that referenced this issue Jun 15, 2021
We now support Redis 6.2 ZMSCORE through the Template API and on the connection level for all drivers.

Closes #2038
mp911de added a commit that referenced this issue Jun 23, 2021
We now support Redis 6.2 ZMSCORE through the Template API and on the connection level for all drivers.

Closes #2038
@mp911de mp911de linked a pull request Jun 28, 2021 that will close this issue
christophstrobl pushed a commit that referenced this issue Jun 28, 2021
We now support Redis 6.2 ZMSCORE through the Template API and on the connection level for all drivers.

Closes #2038
@christophstrobl christophstrobl added this to the 2.6 M1 (2021.1.0) milestone Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants