Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DATAREDIS-1140 - Add support to Redis Streams using Jedis Client #1977

Closed
wants to merge 4 commits into from
Closed

DATAREDIS-1140 - Add support to Redis Streams using Jedis Client #1977

wants to merge 4 commits into from

Conversation

dengliming
Copy link
Contributor

@dengliming dengliming commented Feb 18, 2021 •
edited
Loading

resolves #1711

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 18, 2021
@dengliming dengliming changed the title Add support to Redis Streams using Jedis Client DATAREDIS-1140 - Add support to Redis Streams using Jedis Client Feb 18, 2021
mp911de
mp911de reviewed Feb 18, 2021
View reviewed changes
Copy link
Member

@mp911de mp911de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, great work. I left a few comments, mostly high-level aspects. Care to have a look?

src/main/java/org/springframework/data/redis/connection/jedis/JedisStreamCommands.java
maxLength = options.getMaxlen();
}

return connection.invoke().from(BinaryJedis::xadd, MultiKeyPipelineBase::xadd, record.getStream(), id,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, we introduced the invoker just recently.

src/main/java/org/springframework/data/redis/connection/jedis/JedisStreamCommands.java Outdated Show resolved Hide resolved
src/main/java/org/springframework/data/redis/connection/jedis/JedisStreamCommands.java Show resolved Hide resolved
src/main/java/org/springframework/data/redis/connection/jedis/JedisStreamCommands.java Outdated Show resolved Hide resolved
src/main/java/org/springframework/data/redis/connection/jedis/StreamConverters.java Outdated Show resolved Hide resolved
@mp911de mp911de self-assigned this Mar 12, 2021
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 12, 2021
@mp911de mp911de added this to the 2.5 M5 (2021.0.0) milestone Mar 12, 2021
mp911de pushed a commit that referenced this pull request Mar 16, 2021
@dengliming @mp911de
Add support to Redis Streams using Jedis.
a31c739 
Closes #1711
Original pull request: #1977.
mp911de added a commit that referenced this pull request Mar 16, 2021
@mp911de
Polishing.
9b39c09 
Add support for Jedis Streams using JedisCluster. Add fromMany(…) for non-pipelined usage to JedisInvoker.

Reformat code, add author tags. Extract Jedis-specific stream type converters to StreamConverters. Properly convert StreamEntry and StreamEntryID into list/map. Update tests.

See #1711
Original pull request: #1977.
@mp911de
Copy link
Member

mp911de commented Mar 16, 2021

Thank you for your contribution. That's merged and polished now.

@mp911de mp911de closed this Mar 16, 2021
@dengliming dengliming deleted the DATAREDIS-1140 branch March 16, 2021 09:38
christophstrobl added a commit that referenced this pull request Mar 25, 2021
@christophstrobl
Guard tests when no cluster available.
b2349fd 
See #1711
Original Pull Request: #1977
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de mp911de left review comments

Assignees

@mp911de mp911de

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.5 M5 (2021.0.0)
Development

Successfully merging this pull request may close these issues.

Add support to Redis Streams using Jedis Client [DATAREDIS-1140]
3 participants
@dengliming @mp911de @spring-projects-issues