-
Notifications
You must be signed in to change notification settings - Fork 38.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DateTimeFormat ISO.DATE_TIME javadoc contains misleading default note #26134
Labels
in: core
Issues in core modules (aop, beans, core, context, expression)
status: backported
An issue that has been backported to maintenance branches
type: documentation
A documentation task
Milestone
Comments
spring-projects-issues
added
the
status: waiting-for-triage
An issue we've not yet triaged or decided on
label
Nov 23, 2020
jhoeller
added
in: core
Issues in core modules (aop, beans, core, context, expression)
type: documentation
A documentation task
and removed
status: waiting-for-triage
An issue we've not yet triaged or decided on
labels
Nov 23, 2020
Good catch, the actual default is dependent on the formatter backend (JSR-310 vs Joda-Time vs java.util.Date infrastructure), so that javadoc comment on the |
jhoeller
changed the title
DateTimeFormat ISO values - JavaDoc information out of date?!
DateTimeFormat ISO.DATE_TIME javadoc makes misleading default claim
Nov 23, 2020
jhoeller
changed the title
DateTimeFormat ISO.DATE_TIME javadoc makes misleading default claim
DateTimeFormat ISO.DATE_TIME javadoc contains misleading default note
Nov 23, 2020
spring-projects-issues
added
status: backported
An issue that has been backported to maintenance branches
and removed
for: backport-to-5.2.x
labels
Nov 23, 2020
zx20110729
pushed a commit
to zx20110729/spring-framework
that referenced
this issue
Feb 18, 2022
Closes spring-projectsgh-26134 (cherry picked from commit 86f9716)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
in: core
Issues in core modules (aop, beans, core, context, expression)
status: backported
An issue that has been backported to maintenance branches
type: documentation
A documentation task
Affects: 5.2.10.RELEASE
Maybe I'm missing something, but I think the JavaDoc on the @DateTimeFormat is out of date / not correct.
The DateTimeFormat.ISO#DATE_TIME JavaDoc states, that the DATE_TIME is the default used, when no iso value is specified:
However, when looking at the DateTimeFormat#iso() implementation, it's as follows:
So there clearly is a mismatch. Is it just an outdated JavaDoc issue?
The text was updated successfully, but these errors were encountered: