Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase scope of regex pattern cache for the SpEL matches operator #30140

Closed
sbrannen opened this issue Mar 19, 2023 · 0 comments
Closed

Increase scope of regex pattern cache for the SpEL matches operator #30140

sbrannen opened this issue Mar 19, 2023 · 0 comments
Assignees
@sbrannen
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone
6.0.7

Comments

@sbrannen
Copy link
Member

The pattern cache for the SpEL matches operator only applies to expressions such as the following where the same matches operator is invoked multiple times with different input:

map.keySet().?[#this matches '.+xyz']

The pattern cache does not apply to expressions such as the following where the same pattern (.+xyz) is used in multiple matches operations:

foo matches '.+xyz' AND bar matches '.+xyz'

We should increase the scope of the regex pattern cache for the SpEL matches operator so that the cache can be reused for all matches operations for the given parser.
@sbrannen sbrannen added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Mar 19, 2023
@sbrannen sbrannen added this to the 6.0.7 milestone Mar 19, 2023
@sbrannen sbrannen self-assigned this Mar 19, 2023
@github-actions github-actions bot added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.3.x labels Mar 19, 2023
@github-actions github-actions bot mentioned this issue Mar 19, 2023
Closed
@github-actions github-actions bot mentioned this issue Mar 20, 2023
Closed
izeye added a commit to izeye/spring-framework that referenced this issue Mar 23, 2023
@izeye
Update versions in Javadoc for spring-projectsgh-30140, spring-projec…
e75a4ff 
…tsgh-30142, and spring-projectsgh-30144

See spring-projectsgh-30140
See spring-projectsgh-30142
See spring-projectsgh-30144
@izeye izeye mentioned this issue Mar 23, 2023
Closed
jgallimore pushed a commit to tomitribe/spring-framework that referenced this issue Mar 31, 2023
@sbrannen @jgallimore
Increase scope of regex pattern cache for the SpEL matches operator
caafa31 
Prior to this commit, the pattern cache for the SpEL `matches` operator
only applied to expressions such as the following where the same
`matches` operator is invoked multiple times with different input:

  "map.keySet().?[#this matches '.+xyz']"

The pattern cache did not apply to expressions such as the following
where the same pattern ('.+xyz') is used in multiple `matches`
operations:

  "foo matches '.+xyz' AND bar matches '.+xyz'"

This commit addresses this by moving the instance of the pattern cache
map from OperatorMatches to InternalSpelExpressionParser so that the
cache can be reused for all `matches` operations for the given parser.

Closes spring-projectsgh-30140
jgallimore pushed a commit to tomitribe/spring-framework that referenced this issue Mar 31, 2023
@sbrannen @jgallimore
Increase scope of regex pattern cache for the SpEL matches operator
d3e0d49 
Prior to this commit, the pattern cache for the SpEL `matches` operator
only applied to expressions such as the following where the same
`matches` operator is invoked multiple times with different input:

  "map.keySet().?[#this matches '.+xyz']"

The pattern cache did not apply to expressions such as the following
where the same pattern ('.+xyz') is used in multiple `matches`
operations:

  "foo matches '.+xyz' AND bar matches '.+xyz'"

This commit addresses this by moving the instance of the pattern cache
map from OperatorMatches to InternalSpelExpressionParser so that the
cache can be reused for all `matches` operations for the given parser.

Closes spring-projectsgh-30140
@cxronen cxronen mentioned this issue Apr 13, 2023
Open
@oscardatastream oscardatastream mentioned this issue Apr 26, 2023
Open
@cxronen cxronen mentioned this issue May 25, 2023
Open
@diogopcx diogopcx mentioned this issue Jun 27, 2023
Open
@AASMACMX AASMACMX mentioned this issue Apr 26, 2023
Open
@cxronen cxronen mentioned this issue Jul 19, 2023
Open
@AASMACMX AASMACMX mentioned this issue Jul 10, 2023
Open
@apcxtest apcxtest mentioned this issue Aug 17, 2023
Closed
@Sang140790 Sang140790 mentioned this issue Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.7
Development

No branches or pull requests
1 participant
@sbrannen