Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve checks for relative paths in static resource handling #33689

Closed
rstoyanchev opened this issue Oct 11, 2024 · 0 comments
Closed

Improve checks for relative paths in static resource handling #33689

rstoyanchev opened this issue Oct 11, 2024 · 0 comments
Assignees
@rstoyanchev
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
6.1.14

Comments

@rstoyanchev
Copy link
Contributor

Going forward with #33687 we are going to drop support for relative paths entirely. For the current 6.1.x branch, we can revise handling with the understanding that while the use case is still supported it is also likely not very common.
@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Oct 11, 2024
@rstoyanchev rstoyanchev added this to the 6.1.14 milestone Oct 11, 2024
@rstoyanchev rstoyanchev self-assigned this Oct 11, 2024
rstoyanchev added a commit that referenced this issue Oct 14, 2024
@rstoyanchev
Update processPath for double encoding
fb7890d 
See gh-33689
cesarhernandezgt pushed a commit to cesarhernandezgt/spring-framework that referenced this issue Oct 30, 2024
@rstoyanchev @cesarhernandezgt
Normalize static resource path early
0270f00 
Rather than leaving it to the Resource implementation, and
potentially normalizing twice, we apply it once as part of the
initial processPath checks.

Closes spring-projectsgh-33689

(cherry picked from commit 3bfbe30)
cesarhernandezgt pushed a commit to cesarhernandezgt/spring-framework that referenced this issue Oct 30, 2024
@rstoyanchev @cesarhernandezgt
Update processPath for double encoding
6f22dbb 
See spring-projectsgh-33689

(cherry picked from commit fb7890d)
cesarhernandezgt pushed a commit to cesarhernandezgt/spring-framework that referenced this issue Nov 4, 2024
@rstoyanchev @cesarhernandezgt
Normalize static resource path early
c3187ec 
Rather than leaving it to the Resource implementation, and
potentially normalizing twice, we apply it once as part of the
initial processPath checks.

Closes spring-projectsgh-33689

(cherry picked from commit 3bfbe30)
cesarhernandezgt pushed a commit to cesarhernandezgt/spring-framework that referenced this issue Nov 4, 2024
@rstoyanchev @cesarhernandezgt
Update processPath for double encoding
bf44f69 
See spring-projectsgh-33689

(cherry picked from commit fb7890d)
RxL-Deepak-Agrawal pushed a commit to RxL-Deepak-Agrawal/spring-framework that referenced this issue Nov 26, 2024
@rstoyanchev @RxL-Deepak-Agrawal
Normalize static resource path early
720a15a 
Rather than leaving it to the Resource implementation, and
potentially normalizing twice, we apply it once as part of the
initial processPath checks.

Closes spring-projectsgh-33689

(cherry picked from commit 3bfbe30)
RxL-Deepak-Agrawal pushed a commit to RxL-Deepak-Agrawal/spring-framework that referenced this issue Nov 26, 2024
@rstoyanchev @RxL-Deepak-Agrawal
Update processPath for double encoding
e40f0ae 
See spring-projectsgh-33689

(cherry picked from commit fb7890d)
lijunyzzZ pushed a commit to succsoft/spring-framework that referenced this issue Dec 4, 2024
@rstoyanchev @lijunyzzZ
Normalize static resource path early
ba05787 
Rather than leaving it to the Resource implementation, and
potentially normalizing twice, we apply it once as part of the
initial processPath checks.

Closes spring-projectsgh-33689
lijunyzzZ pushed a commit to succsoft/spring-framework that referenced this issue Dec 4, 2024
@rstoyanchev @lijunyzzZ
Update processPath for double encoding
17b6a1e 
See spring-projectsgh-33689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.14
Development

No branches or pull requests
1 participant
@rstoyanchev