Fix ScriptUtils for MS Windows line ending #23019
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chrunchyjesus Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
I do not care what gets done with my code and I do not want to sign in to that platform either. If that is not acceptable then someone should create another PR that fixes this bug. |
|
Since this is a trivial change, we have decided to forgo the requirement to sign the CLA. Thanks for your contribution! |
sbrannen
added
in: data
sbrannen
changed the title
sbrannen
changed the title
spring-projects-issues
added
status: backported
sbrannen
pushed a commit
to sbrannen/spring-framework
that referenced
this pull request
May 24, 2019
Prior to this commit, ScriptUtils did not properly split SQL scripts that contained line endings for MS Windows. Closes spring-projectsgh-23019
sbrannen
pushed a commit
that referenced
this pull request
May 24, 2019
Prior to this commit, ScriptUtils did not properly split SQL scripts that contained line endings for MS Windows. Closes gh-23019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shamelessly copied from testcontainers/testcontainers-java#1467
Since Testcontainers copied ScriptUtils from this repo, the same bug exists here too.