Introduce DurationEditor for java.time.Duration support #28084
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, in a project that is using spring-framework (no spring-boot), I saw a
@Configuration
class witha lot of configuration about timeouts injected as plain
long
(most likely milliseconds but it is not explicitly documented, as often it happens):With this small patch, it would be possible to directly inject a
Duration
:In my opinion, this is less error prone, as usually these configuration values must be adjusted with some calculations (i.e. seconds to milliseconds).
This patch allows two formats:
PT10s
,PT1m30s
(asDuration.parse
);10s
,1m
,2h
(IMHO this format is very readable for properties files).Comments and feedback is welcome. I'm not sure about using a property editor, perhaps a
Converter
is a better choice?And I'm not sure if this should be mentioned somewhere in the spring-reference... please advice :-)