Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open observation scope in RestClient #33404

Closed
wants to merge 1 commit into from

Conversation

prkksh
Copy link

@prkksh prkksh commented Aug 18, 2024

This is to address issue - RestClient doesn't open a scope for the processing of the request #33397. The scope is now opened and properly closed, which ensures that any observations captured during the execution are appropriately handled, even in the presence of exceptions.

Changes

  • Refactored exchangeInternal method to manage Observation.Scope more effectively.
  • Added a test to verify the proper creation and closure of the observation scope.

@bclozel
Copy link
Member

bclozel commented Aug 19, 2024

Thanks for the proposal @prkksh but the issue was already assigned and work was in progress. You can see that I went with different changes in #33397.

@bclozel bclozel closed this Aug 19, 2024
@bclozel bclozel added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants