Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use encoded resource path instead of input path validation in spring-webflux #33568

Closed
wants to merge 1 commit into from
Closed

Use encoded resource path instead of input path validation in spring-webflux #33568

wants to merge 1 commit into from

Conversation

drdpov
Copy link

@drdpov drdpov commented Sep 19, 2024

This pull request adds minor fix, to the validation introduced here: d86bf8b when resolving issue #33434
It seems that in the initial fix for spring-webmvc was created correctly, but for spring-webflux validation method was used incorrectly

@drdpov drdpov mentioned this pull request Sep 19, 2024
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Sep 19, 2024
@rstoyanchev rstoyanchev self-assigned this Sep 19, 2024
@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Sep 19, 2024
@rstoyanchev rstoyanchev changed the title Use encoded resource path validation instead of input path validation in spring-webflux Use encoded resource path instead of input path validation in spring-webflux Sep 19, 2024
@rstoyanchev rstoyanchev added this to the 6.1.14 milestone Sep 19, 2024
rstoyanchev
rstoyanchev approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@rstoyanchev rstoyanchev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that. Thankfully quite similar, but we should use the one that's intended and is more targeted.

@rstoyanchev
Copy link
Contributor

Those method are now re-used, see #33574.

cesarhernandezgt pushed a commit to cesarhernandezgt/spring-framework that referenced this pull request Oct 30, 2024
@cesarhernandezgt
Use correct method to check encoded resource path
302edca 
Closes: spring-projectsgh-33568
(cherry picked from commit 94c0482)
cesarhernandezgt pushed a commit to cesarhernandezgt/spring-framework that referenced this pull request Nov 4, 2024
@cesarhernandezgt
Use correct method to check encoded resource path
0d98c96 
Closes: spring-projectsgh-33568
(cherry picked from commit 94c0482)
RxL-Deepak-Agrawal pushed a commit to RxL-Deepak-Agrawal/spring-framework that referenced this pull request Nov 26, 2024
@RxL-Deepak-Agrawal
Use correct method to check encoded resource path
21fe6cf 
Closes: spring-projectsgh-33568
(cherry picked from commit 94c0482)
lijunyzzZ pushed a commit to succsoft/spring-framework that referenced this pull request Dec 4, 2024
@lijunyzzZ
Use correct method to check encoded resource path
77c97a2 
Closes: spring-projectsgh-33568
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rstoyanchev rstoyanchev rstoyanchev approved these changes

Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Projects
None yet
Milestone
6.1.14
Development

Successfully merging this pull request may close these issues.
3 participants
@drdpov @rstoyanchev @spring-projects-issues