-
Notifications
You must be signed in to change notification settings - Fork 38.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax the visibility of MockMVC DSL constructors #33778
Conversation
@Hejow Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@Hejow Thank you for signing the Contributor License Agreement! |
Adding RestDocs specific code in Spring Framework is not ok, I would favor relaxing the visibility of the constructor. Could you please refine the PR accordingly and add related test, or create a related issue and close this PR? |
Thank you for ur feedback! |
d6b7cae
to
31732ac
Compare
31732ac
to
a940570
Compare
@sdeleuze Sorry that im lateee.. 😭 |
Could we use |
@sdeleuze I love to restrict visibility of the constructors. p.s. thx for ur feedbacks!!! 👍 |
Ah yeah, indeed. |
Squashed and merged, thanks! |
Hello, I added Kotlin DSL for RestDocs.
At first, I thought this PR might be more suitable for
spring-restdocs
, so I was confused where to make PR.Due to the
internal constructor
, I’m submitting the PR here.I positioned the package with the following three considerations in mind
I would appreciate any feedback on this PR. Thank You!!