-
Notifications
You must be signed in to change notification settings - Fork 38.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add trailing slash to static resource location if missing #33817
Add trailing slash to static resource location if missing #33817
Conversation
@cagliostro92 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@cagliostro92 Thank you for signing the Contributor License Agreement! |
dc3ea16
to
0b7ebb8
Compare
0b7ebb8
to
becc24c
Compare
Hi @bclozel, |
Thanks for the proposal, but I'm declining this one in favor of #33815 (comment) |
Re-opening as per discussion under #33826. |
becc24c
to
7cb8a4f
Compare
Thanks for the PR, and I will apply equivalent changes, but I need to start in 6.1.x where the code is different, and then forward merge to main. |
As already stressed by @philwebb in #33815 and by my colleague @milazzo-g, the brand new assertion about the required trailing slash can lead to important breaking changes in both custom project and libraries. As mentioned by the author in #33712:
It seems to be clear that this constraint was intended to avoid unexpected behaviour, but the framework can still be accountable for adding the trailing slash without breaking other projects.
closes: #33815