INT-4458: Do not expose recursive generics API #2432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA: https://jira.spring.io/browse/INT-4458 According Kotlin generics system restrictions we can't expose API based on the recursive generics, like we have with Java DSL for JMS * Replace explicit recursive generics on factory method with the wildcard (`?`). This way both Kotlin and Java are able to instantiate target object and perform the proper chain API auto-completion * Fix `JmsInboundChannelAdapterSpec` to deal with provided `S` type for the `configureListenerContainer()` - the way we can configure a `JmsDefaultListenerContainerSpec` * Add `kotlin-spring` Gradle plugin to avoid extra `open` modificator on `@Bean` methods * Add `JmsDslKotlinTests.kt` **Cherry-pick to 5.0.x excluding Kotlin support**
|
If that's OK, I can go ahead and fix similar problem in AMQP DSL and other. |
|
LGTM; do you want to do the others in this PR? Or a separate one? |
|
Well, I can do in the separate PR(s), but then it's more work during cherry-picking. |
|
Looks like nothing more to fix. Thanks |
|
Oh! Looks like we have back-ported Kotlin tests to |
garyrussell
pushed a commit
that referenced
this pull request
May 1, 2018
* INT-4458: Do not expose recursive generics API JIRA: https://jira.spring.io/browse/INT-4458 According Kotlin generics system restrictions we can't expose API based on the recursive generics, like we have with Java DSL for JMS * Replace explicit recursive generics on factory method with the wildcard (`?`). This way both Kotlin and Java are able to instantiate target object and perform the proper chain API auto-completion * Fix `JmsInboundChannelAdapterSpec` to deal with provided `S` type for the `configureListenerContainer()` - the way we can configure a `JmsDefaultListenerContainerSpec` * Add `kotlin-spring` Gradle plugin to avoid extra `open` modificator on `@Bean` methods * Add `JmsDslKotlinTests.kt` **Cherry-pick to 5.0.x excluding Kotlin support** * Fix `Amqp` DSL factory for recursive generics * Polishing for Kotlin tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.spring.io/browse/INT-4458
According Kotlin generics system restrictions we can't expose API
based on the recursive generics, like we have with Java DSL for JMS
?).This way both Kotlin and Java are able to instantiate target object and perform
the proper chain API auto-completion
JmsInboundChannelAdapterSpecto deal with providedStype for theconfigureListenerContainer()- the way we can configure aJmsDefaultListenerContainerSpeckotlin-springGradle plugin to avoid extraopenmodificator on@BeanmethodsJmsDslKotlinTests.ktCherry-pick to 5.0.x excluding Kotlin support