GH-2464: WebFlux: Get rid of Mono.block() #2465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#2464 The `WebFluxInboundEndpoint` resolves a `Principal` via `Mono.block()` operation. This is prohibited situation in the non-blocking thread, like Reactor Netty * Defer `Mono<Principal>` resolution to the message header via deferring the whole `Message` creating via `flatMap()` operation on the main `doHandle()` `Mono` **Cherry-pick to 5.0.x**
|
Checkstyle errors |
…c imports * Add `defaultIfEmpty()`, when `exchange.getPrincipal()` is an empty `Mono`
garyrussell
pushed a commit
that referenced
this pull request
Jun 11, 2018
* GH-2464: WebFlux: Get rid of Mono.block() Fixes #2464 The `WebFluxInboundEndpoint` resolves a `Principal` via `Mono.block()` operation. This is prohibited situation in the non-blocking thread, like Reactor Netty * Defer `Mono<Principal>` resolution to the message header via deferring the whole `Message` creating via `flatMap()` operation on the main `doHandle()` `Mono` **Cherry-pick to 5.0.x** * * Fix Checkstyle for the Reactive Spring Security testing utils static imports * Add `defaultIfEmpty()`, when `exchange.getPrincipal()` is an empty `Mono`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2464
The
WebFluxInboundEndpointresolves aPrincipalviaMono.block()operation.
This is prohibited situation in the non-blocking thread, like Reactor
Netty
Mono<Principal>resolution to the message header viadeferring the whole
Messagecreating viaflatMap()operation on themain
doHandle()MonoCherry-pick to 5.0.x