GH-9453: Correct separator when checking smb path #9454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pfosser Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@pfosser This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary. |
artembilan
requested changes
Sep 12, 2024
| import org.springframework.core.log.LogAccessor; | ||
| import org.springframework.integration.file.remote.session.Session; | ||
| import org.springframework.util.Assert; | ||
| import org.springframework.util.FileCopyUtils; | ||
| import org.springframework.util.StringUtils; | ||
|
|
||
| import jcifs.smb.SmbException; | ||
| import jcifs.smb.SmbFile; | ||
| import jcifs.smb.SmbFileOutputStream; |
There was a problem hiding this comment.
This is not correct change.
Please, consider to revert imports order.
artembilan
requested changes
Sep 12, 2024
There was a problem hiding this comment.
The build fails clearly with that import order problem:
Error: eckstyle] [ERROR] /home/runner/work/spring-integration/spring-integration/spring-integration-smb/src/main/java/org/springframework/integration/smb/session/SmbSession.java:34:1: Wrong order for 'jcifs.smb.SmbException' import. [ImportOrder]
Consider to run ./gradlew :spring-integration-smb:check before pushing changes to the PR.
Thanks
Fixes: spring-projects#9453 Issue link: spring-projects#9453 On a smb file upload, to detect the need for new remote directories, the remote path was checked for the local filesystem path separator. On Windows that is \\ which is never found in a smb path, so the necessary remote path was not created and the operation failed. Use the correct separator which was already available as a constant.
|
@pfosser , thank you for contribution; looking forward for more! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9453
Issue link: #9453
On a smb file upload, to detect the need for new remote directories, the remote path was checked for the local filesystem path separator. On Windows that is \ which is never found in a smb path, so the necessary remote path was not created and the operation failed.
Use the correct separator which was already available as a constant.
@pivotal-cla This is an Obvious Fix