Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReplyingKT - Improve Readability of Correlation Id in Logs #2400

Closed
garyrussell opened this issue Sep 20, 2022 · 0 comments · Fixed by #2401
Closed

ReplyingKT - Improve Readability of Correlation Id in Logs #2400

garyrussell opened this issue Sep 20, 2022 · 0 comments · Fixed by #2401
Assignees
@garyrussell
Labels
backport 2.9.x (obsolete) ideal-for-user-contribution An issue that would ideal for a user to get started with contributing. type: improvement
Milestone
3.0.0-RC1

Comments

@garyrussell
Copy link
Contributor

Currently, the CorrelationKey uses a BigInteger in toString().

Represent the value as a hex string instead.

Related to #2399
@garyrussell garyrussell added type: improvement ideal-for-user-contribution An issue that would ideal for a user to get started with contributing. backport 2.9.x (obsolete) labels Sep 20, 2022
@garyrussell garyrussell added this to the 3.0.0-RC1 milestone Sep 20, 2022
@garyrussell garyrussell self-assigned this Sep 20, 2022
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Sep 20, 2022
@garyrussell
spring-projectsGH-2400: ReplyingKT Improve CorrelationId Logging
771031c 
Resolves spring-projects#2400

Use a hex string instead of a `BigInteger` in `toString`. Also, if the
bytes are the length of a UUID, use the standard representation thereof.

**cherry-pick to 2.9.x**
@garyrussell garyrussell mentioned this issue Sep 20, 2022
Merged
artembilan pushed a commit that referenced this issue Sep 20, 2022
@garyrussell @artembilan
GH-2400: ReplyingKT Improve CorrelationId Logging
10b75a3 
Resolves #2400

Use a hex string instead of a `BigInteger` in `toString`. Also, if the
bytes are the length of a UUID, use the standard representation thereof.

**cherry-pick to 2.9.x**
artembilan pushed a commit that referenced this issue Sep 20, 2022
@garyrussell @artembilan
GH-2400: ReplyingKT Improve CorrelationId Logging
5fed903 
Resolves #2400

Use a hex string instead of a `BigInteger` in `toString`. Also, if the
bytes are the length of a UUID, use the standard representation thereof.

**cherry-pick to 2.9.x**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyrussell garyrussell

Labels
backport 2.9.x (obsolete) ideal-for-user-contribution An issue that would ideal for a user to get started with contributing. type: improvement
Projects
None yet
Milestone
3.0.0-RC1
Development

Successfully merging a pull request may close this issue.

GH-2400: ReplyingKT Improve CorrelationId Logging garyrussell/spring-kafka
1 participant
@garyrussell