Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meta-annotation support to RetryableTopic #2440

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

fablakeson
Copy link
Contributor

This PR resolves #2435

With this change we will be able to create new annotations, meta-annotated with RetryableTopic. This makes it possible to share the same configurations from a RetryableTopic annotation across multiple KafkaListener annotated methods, making configuration details transparent, reducing boilerplate.

@garyrussell
Copy link
Contributor

@fablakeson Thanks for the PR. looks like it’s simple enough that it can be included in tomorrow’s release candidate. I have scheduled a second RC in a couple of weeks. Happy to include the merged annotation enhancements in that if you have time to work on that.

@garyrussell
Copy link
Contributor

Please add yourself in an @author tag to each changed file. Also update the copyright to 2022 where necessary.

@fablakeson
Copy link
Contributor Author

Authorship added, thanks for accepting this PR. I will work on merged annotations enhancements over the next week.

@garyrussell garyrussell merged commit 67e0ed1 into spring-projects:main Oct 17, 2022
@garyrussell
Copy link
Contributor

@fablakeson Thanks; I opened a new issue for that. #2441

@fablakeson fablakeson deleted the GH-2435 branch October 18, 2022 05:29
@garyrussell
Copy link
Contributor

I will work on merged annotations enhancements over the next week.

@fablakeson The release candidate is due Nov 3; I can take this over if you won't have time.

@fablakeson
Copy link
Contributor Author

@garyrussell sorry for the late, just sent it today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Meta-Annotation Support to @RetryableTopic
2 participants