Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more whats-new for kakfa-client 3.7.0 #3253

Merged
merged 2 commits into from
May 16, 2024

Conversation

sobychacko
Copy link
Contributor

  • Clarify the usage of the new consumer-group protocol in the 3.7.0 version of the client
  • Add a note on the usage of EmbeddedKafka in kraft mode

* Clarify the usage of the new consumer-group protocol in the 3.7.0 version of the client
* Add a note on the usage of `EmbeddedKafka` in `kraft` mode
Therefore, Spring for Apache Kafka supports this new consumer group protocol only to the extent of such testing level support available in the `kafka-client` itself.
By default, Spring for Apache Kafka uses the classic consumer group protocol and when testing the new consumer group protocol, that needs to be opted-in via the `group.protocol` property on the consumer.

When using the `EmbeddedKafka` with the 3.7.0 version of the `kafka-client`, the `kraft` mode is disabeld by default.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence does not reflect reality.
We have it kraft = false compiled-in. Independently of the Kafka client.

I would suggest to have a dedicated bullet for the Testing Support Changes and explain there why we turned it off.
But I believe that has nothing to do with Kafka client 3.7.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya, i hear your point. I actually thought about it. However, the new consumer-group protocol testing with EmbeddedKafka in kraft mode may still be relevant here. What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, there is catch 22. The new consumer group protocol works only in KRaft mode.
And unfortunately, only with real broker, not one created by the KafkaClusterTestKit.
Then we also saw some flaws for classic group management in KRaft mode.
So, this or other way kraft mode is not recommended with @EmbeddedKafka.

@artembilan artembilan added this to the 3.2.0 milestone May 16, 2024
@artembilan artembilan merged commit 0eb3462 into spring-projects:main May 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants