GH-3402: kafkaAdmin clusterId configuration is ignored if observability is enabled and bootstrap supplier is not set #3403
Conversation
|
@varmenise Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@varmenise Thank you for signing the Contributor License Agreement! |
… if observability is enabled and bootstrap supplier is not set fixes spring-projectsGH-3402 (spring-projects#3402) * Re-set clusterId after creating new KafkaAdmin
There was a problem hiding this comment.
I think I'm OK with this.
Although some unit test to cover would be nice.
Or modify existing one ObservationIntegrationTests.
Please, also run ./gradlew check locally to be sure in all the passing tests and Checkstyle rules.
Then add you name to the @author list of the affected classes.
| * @since 3.3.0 | ||
| */ | ||
| public String getClusterId() { | ||
| return clusterId; |
| @@ -213,6 +213,14 @@ public void setClusterId(String clusterId) { | |||
| this.clusterId = clusterId; | |||
| } | |||
|
|
|||
| /** | |||
| * Get the clusterId property. | |||
| * @since 3.3.0 | |||
There was a problem hiding this comment.
Since we have agreed that this is a bug and there is no easy workaround (but fix is simple), then this one is going to be back-ported to supported versions. Therefore this @since is 3.1.8
|
I ll fix this as I get some time, thanks for reviewing! |
|
@varmenise , Thanks |
|
Merged via: f11c7ca Backporte to |
fixes GH-3402 (#3402)