Change "synchronized" to reentrant lock for virtual-threads #3652
Conversation
| @@ -267,12 +272,16 @@ public final boolean initialize() { | |||
| } | |||
| if (adminClient != null) { | |||
| try { | |||
| synchronized (this) { | |||
| try { | |||
There was a problem hiding this comment.
Can we use only one try block? I think, you can move the unlocking to the finally block on the main try.
There was a problem hiding this comment.
Hi @sobychacko .
If I follow your suggestion, I will unnecessarily include the addOrModifyTopicsIfNeeded method within the locked block. I reviewed the addOrModifyTopicsIfNeeded method, and I believe it performs time-consuming operations. Therefore, I prefer not to place that method inside the lock block. I prefer releasing the lock as quickly as possible. If you don’t mind, I’d like to leave it as it is.
There was a problem hiding this comment.
That makes sense. I guess you can try to extract that inner try block into a separate private method - something like updateClusterId(...) and then call that in the current method. That way, we can avoid stacking one try block on another and thus look less cluttered.
There was a problem hiding this comment.
You're right, I'll fix it right away.
| Object config = configs.get(ADD_TYPE_INFO_HEADERS); | ||
| if (config instanceof Boolean configBoolean) { | ||
| this.addTypeInfo = configBoolean; | ||
| try { |
There was a problem hiding this comment.
Forgot to remove the synchronized keyword from the method signature?
@sobychacko I've applied the updates; could you review it again? |
|
@omercelikceng Thanks for the PR. Merged if via 3c97a3b. |
…pport Fixes: #3652 Replace synchronized methods and blocks with ReentrantLocks in a few classes in Spring Kafka to improve compatibility with virtual threads. This changes the synchronization mechanism in: - KafkaListenerAnnotationBeanPostProcessor - KafkaListenerEndpointRegistrar - KafkaAdmin - DefaultDestinationTopicResolver - JsonDeserializer/JsonSerializer The change helps avoid blocking virtual threads when using Spring Kafka in Project Loom environments while maintaining thread safety.
This commit ensures that the method is friendly for virtual threads to avoid blocking and pinning. The lock is acquired at the beginning of the method and released in a finally block to ensure it is always released, even if an exception occurs.