Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to use REST Docs with the new org.asciidoctor.jvm.convert Gradle plugin #744

Closed
wants to merge 5 commits into from
Closed

Document how to use REST Docs with the new org.asciidoctor.jvm.convert Gradle plugin #744

wants to merge 5 commits into from

Conversation

brneto
Copy link

@brneto brneto commented Aug 23, 2021

closes #743

wilkinsona
wilkinsona requested changes Aug 24, 2021
View reviewed changes
Copy link
Member

@wilkinsona wilkinsona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @brneto. This looks like it addresses #680 rather than #743. I've left a few comments for your consideration when you have a moment.

docs/src/docs/asciidoc/getting-started.adoc Outdated Show resolved Hide resolved
docs/src/docs/asciidoc/getting-started.adoc Show resolved Hide resolved
docs/src/docs/asciidoc/getting-started.adoc Outdated Show resolved Hide resolved
docs/src/docs/asciidoc/getting-started.adoc Show resolved Hide resolved
docs/src/docs/asciidoc/getting-started.adoc Outdated Show resolved Hide resolved
docs/src/docs/asciidoc/getting-started.adoc Outdated Show resolved Hide resolved
docs/src/docs/asciidoc/getting-started.adoc Show resolved Hide resolved
@brneto
Copy link
Author

brneto commented Aug 25, 2021

@wilkinsona do you agree with my changes now?

@wilkinsona wilkinsona added this to the 2.0.6.RELEASE milestone Sep 7, 2021
@wilkinsona wilkinsona self-requested a review September 7, 2021 08:24
@wilkinsona wilkinsona changed the title Update Gradle examples to use configurations for dependencies that are Gradle 7-compatible Document how to use REST Docs with the new org.asciidoctor.jvm.convert Gradle plugin Jan 10, 2022
@wilkinsona wilkinsona mentioned this pull request Jan 10, 2022
Closed
wilkinsona pushed a commit that referenced this pull request Jan 10, 2022
@wilkinsona
Document how to use org.asciidoctor.jvm.convert Gradle plugin
0952e5f 
See gh-744
wilkinsona added a commit that referenced this pull request Jan 10, 2022
@wilkinsona
Polish "Document how to use org.asciidoctor.jvm.convert Gradle plugin"
acd60c7 
See gh-744
@wilkinsona
Copy link
Member

Thanks very much, @brneto.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilkinsona wilkinsona wilkinsona approved these changes

Assignees
No one assigned
Labels
type: documentation
Projects
None yet
Milestone
2.0.6.RELEASE
Development

Successfully merging this pull request may close these issues.

Update Gradle examples to use configurations for dependencies that are Gradle 7-compatible
3 participants
@brneto @wilkinsona @spring-projects-issues