Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling getMaxAttempts instead of maxAttempts #109

Closed
wants to merge 1 commit into from

Conversation

plummb
Copy link
Contributor

@plummb plummb commented Mar 26, 2018

This is done to support maxAttempts to be configurable at Tenant level in a Multi Tenant Application. In this case, one can simple override getMaxAttempts and return appropriate value based on Context Tenant.

This is done to support maxAttempts to be configurable at Tenant level in a Multi Tenant Application. In this case, one can simple override getMaxAttempts and return appropriate value based on Context Tenant.
Copy link

@abhishekransingh abhishekransingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes more sense.

@artembilan artembilan added this to the 1.3.3 milestone Apr 13, 2022
@artembilan
Copy link
Member

Merged as da577cf.

@plummb ,

sorry for so-o-o long delay.
Looking forward for more!
Now we should be able to review and merge faster 😄

@artembilan artembilan closed this Apr 13, 2022
@pivotal-cla
Copy link

@plummb Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

1 similar comment
@pivotal-cla
Copy link

@plummb Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants