-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default implementations to RetryListener
#326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add your name to the @author
list of all the affected classes.
Also update their copyright to the current 2022
.
There is also a mentioning of RetryListenerSupport
in the README.
Consider, please, revise that docs respectively.
(Not sure if we should mention its deprecation: just remove will be enough)
src/test/java/org/springframework/retry/listener/RetryListenerSupportTests.java
Show resolved
Hide resolved
*/ | ||
@Deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since="2.0.1", forRemoval=true
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
de20035
to
eecec51
Compare
@artembilan Thanks for the feedback! The year in the headers is already 2022 in almost all affected classes. But I've added the |
eecec51
to
140fb96
Compare
thank you for contribution; looking forward for more! |
With Spring Retry 2.0.0, the baseline was lifted from Java 6 to Java 17, which allows to now use default implementations in interfaces.
The only purpose of
RetryListenerSupport
is to provide default implementations forRetryListener
. As such support implementations are no longer required, this PR deprecatesRetryListenerSupport
and adds its default implementations toRetryListener
.