-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul Javadoc of RetryTemplateBuilder
#359
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just great!
Please, update the Copyright of the affected classes to the current year and add your name to the @author
list.
Thanks
@@ -497,10 +506,11 @@ public RetryTemplateBuilder withListener(RetryListener listener) { | |||
} | |||
|
|||
/** | |||
* Appends all provided {@code listeners} to {@link RetryTemplate}'s listener list. | |||
* Appends all provided {@code listeners} to {@link RetryTemplate}'s list of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The method Javadoc must be imperative: https://github.com/spring-projects/spring-framework/wiki/Code-Style#javadoc-formatting
I see that in some place you have it fixed, but not here.
Problems should be fixed. As far as I can see, I'm already mentioned as an |
653fbb8
to
d103ba2
Compare
thank you for contribution; looking forward for more! |
Small correction. This task is not about Noticed "Overhaul Javadoc of RestTemplateBuilder" in v2.0.2 release notes and was very surprised. 😄 |
RetryTemplateBuilder
Fixed. |
While working on
RetryTemplateBuilder
, I noticed a couple of typos, some confusing explanations, a lack of descriptions of error conditions, and that it does not always follow the Spring Framework style guide. So I tried my best to improve it.If you're not happy with some choices I made, feel free to edit it yourself.